[Bug 457709] Review Request: hiran-perizia-sfd-fonts - English asymmetric font
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457709
--- Comment #21 from Paul Flo Williams <paul(a)frixxon.co.uk> 2011-05-07 06:29:10 EDT ---
Right, let's see if we can get this done before this review's third birthday!
1. Package name should be hiran-perizia-fonts, not hiran-perizia-sfd-fonts
2. Version number of the font (from font metadata) is 0.1.0, so that should be
the version number of the package, rather than the date of the SFD file.
(rpmlint will warn about incoherent numbers in the changelog, but ignore that)
3. The %define lines at the top of the spec should now be %global (take a look
at current font spec template)
4. The license should be "GPLv3+ with exceptions" (again, from font metadata)
5. %prep section pollutes top level BUILD directory, so you need to create a
directory with the line %setup -c -T directly after %prep
6. Correcting %prep will allow you to remove the directory ownership line: %dir
%{_fontdir}/
7. fontconfig file needs correcting and simplifying. I would suggest starting
from the simple template again. The font family should probably be sans-serif
instead of serif, although, given its quirky shapes and Hiran's suggestion that
it's a title font, you might want to follow Nicolas's suggestion and go for
"fantasy".
8. (non-blocking) There is an issue with the font metadata, which you'll see if
you pull it into fontmatrix. The font subfamily is explicitly empty when it
should say "Regular", so fontmatrix displays the full font name as "Perizia ?".
However, the font still works in OpenOffice.org as-is. I'll prep a patch for
the SFD if you wish.
9. (non-blocking) fontlint warns about self-intersecting glyphs and missing
extrema, which is quite common. These should be fed back upstream.
That's everything I can see, and it honestly isn't as much as it appears!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years
[Bug 641727] New: Review Request: ming32-libffi: portable foreign function interface library for Fedora MinGW
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ming32-libffi: portable foreign function interface library for Fedora MinGW
Alias: mingw32-libffi
https://bugzilla.redhat.com/show_bug.cgi?id=641727
Summary: Review Request: ming32-libffi: portable foreign
function interface library for Fedora MinGW
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: pbonzini(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years
[Bug 692437] New: Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
https://bugzilla.redhat.com/show_bug.cgi?id=692437
Summary: Review Request: tycho - plugins and extensions for
building Eclipse plugins and OSGI bundles with Maven
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: sochotni(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Story Points: ---
Spec URL: http://sochotni.fedorapeople.org/packages/tycho.spec
SRPM URL: http://sochotni.fedorapeople.org/packages/tycho-0.10.0-1.fc14.src.rpm
Description:
Tycho is a set of Maven plugins and extensions for building Eclipse
plugins and OSGI bundles with Maven. Eclipse plugins and OSGI bundles
have their own metadata for expressing dependencies, source folder
locations, etc. that are normally found in a Maven POM. Tycho uses
native metadata for Eclipse plugins and OSGi bundles and uses the POM
to configure and drive the build. Tycho supports bundles, fragments,
features, update site projects and RCP applications. Tycho also knows
how to run JUnit test plugins using OSGi runtime and there is also
support for sharing build results using Maven artifact repositories.
Note that package is bundling some dependencies, but this has been approved for
bootstrapping by FPC: https://fedorahosted.org/fpc/ticket/59
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years