[Bug 683591] Review Request: tclap - Templatized Command Line Argument Parser
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=683591
Denis Arnaud <denis.arnaud_fedora(a)m4x.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ASSIGNED
Resolution|ERRATA |
Keywords| |Reopened
--- Comment #17 from Denis Arnaud <denis.arnaud_fedora(a)m4x.org> 2011-10-13 04:15:35 EDT ---
======== Formal Review ========
XX: Some work could be performed, optionally.
OK - 1. rpmlint returns neither warning nor error
OK - 2. Package name ('tclap') is fine and matches the spec file name.
OK - 3. Packaging guidelines are met.
OK - 4. License: MIT, which is Fedora approved. Indeed, the text of the
COPYING
file is exactly the same as http://en.wikipedia.org/wiki/MIT_License.
Every source file references the COPYING file and repeats the
disclaimer of the MIT license. The spec file references correctly the
MIT license and the dedicated COPYING file is included in the %doc
part
for all the sub-packages.
OK - 5. The spec file is legible and written in American English.
OK - 6. The source file, namely tclap-1.2.0.tar.gz, is the right one.
Its MD5SUM is: f6ea7c05ef62f920d30e4bde5ee3ec8c
XX - 7. The package builds cleanly, at least on x86_64 (and Fedora 15).
There are a few warnings, reported by both the C++ compiler and
Doxygen. Those warnings could be reported upstream.
OK - 8. BuildRequires are fine.
OK - 9. There is no locale. All the filenames are composed of pure ASCII text.
OK - 10. There is neither shared library nor bundle copy of system library.
The package is not designed to be relocatable.
OK - 11. The package owns all the directories it creates.
OK - 12. The package does not mention files more than once, except for the
basic
documentation (license text).
OK - 13. File permissions are set correctly.
OK - 14. The use of macros is consistent, e.g. %{buildroot}. The %{optflags}
macro is not explicitly used, but configure and make correctly take it
into account.
OK - 15. The package contains only source code and permissable content.
OK - 16. The HTML documentation (generated by Doxygen) goes into a dedicated
-doc sub-package. That latter does not affect the runtime library.
OK - 17. Header files are in the dedicated -devel sub-package. Moreover,
as there is neither library nor binary, the main package is empty
(it contains only the basic documentation). See also
http://lists.fedoraproject.org/pipermail/packaging/2011-July/007865.html
The -devel sub-package correctly requires the base package using
a fully versioned dependency.
SHOULDs:
--------
OK - 18. Upstream includes a separate file for the license text, namely
COPYING.
OK - 19. No translation of description and summary is available.
OK - 20. mock builds cleanly. The package is noarch.
OK - 21. The package contains a few unit tests, showing that it functions as
described.
OK - 22. There is no scriptlet.
OK - 23. pkgconfig is placed within the dedicated -devel sub-package. See also
item #17 above.
OK - 24. There is no dependency outside of standard Fedora directories.
OK - 25. The package does contain neither script/binary nor library. No man
page
is therefore required.
=========== End of Formal Review ==========
==> APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 8 months
[Bug 630216] New: Review Request: ghc-vector-space - Vector & affine spaces, linear maps, and derivatives
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ghc-vector-space - Vector & affine spaces, linear maps, and derivatives
https://bugzilla.redhat.com/show_bug.cgi?id=630216
Summary: Review Request: ghc-vector-space - Vector & affine
spaces, linear maps, and derivatives
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mathstuf(a)gmail.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL:
http://benboeckel.net/packaging/ghc-vector-space/ghc-vector-space.spec
SRPM URL:
http://benboeckel.net/packaging/ghc-vector-space/ghc-vector-space-0.5.9-1...
Description:
Classes and generic operations for
vector spaces and affine spaces. It also defines a type of
infinite towers of generalized derivatives. A generalized
derivative is a linear transformation rather than one of the
common concrete representations (scalars, vectors, matrices,
...).
% lintmock fedora-14-x86_64-bb
ghc-vector-space.src: W: strange-permission vector-space-0.5.9.tar.gz 0640L
ghc-vector-space.src: W: strange-permission ghc-vector-space.spec 0640L
ghc-vector-space.x86_64: W: no-documentation
ghc-vector-space-prof.x86_64: E: devel-dependency ghc-vector-space-devel
ghc-vector-space-prof.x86_64: W: no-documentation
ghc-vector-space-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/vector-space-0.5.9/libHSvector-space-0.5.9_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 8 months
[Bug 683591] Review Request: tclap - Templatized Command Line Argument Parser
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=683591
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Fixed In Version| |hugin-2011.2.0-1.fc16
Resolution| |ERRATA
Last Closed| |2011-10-13 00:34:04
--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> 2011-10-13 00:34:04 EDT ---
hugin-2011.2.0-1.fc16 has been pushed to the Fedora 16 stable repository. If
problems still persist, please make note of it in this bug report.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 8 months
[Bug 648250] New: Review Request: ghc-xss-sanitize - Sanitize untrusted HTML to prevent XSS attacks
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ghc-xss-sanitize - Sanitize untrusted HTML to prevent XSS attacks
https://bugzilla.redhat.com/show_bug.cgi?id=648250
Summary: Review Request: ghc-xss-sanitize - Sanitize untrusted
HTML to prevent XSS attacks
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mathstuf(a)gmail.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL:
http://benboeckel.net/packaging/ghc-xss-sanitize/ghc-xss-sanitize.spec
SRPM URL:
http://benboeckel.net/packaging/ghc-xss-sanitize/ghc-xss-sanitize-0.2.2-1...
Description:
Run untrusted HTML through Text.HTML.SanitizeXSS.sanitizeXSS
to prevent XSS attacks. see README.md
for more details.
% lintmock fedora-14-x86_64-bb
ghc-xss-sanitize.src: W: spelling-error Summary(en_US) untrusted -> entrusted,
untrustful, mistrusted
ghc-xss-sanitize.src: W: spelling-error %description -l en_US untrusted ->
entrusted, untrustful, mistrusted
ghc-xss-sanitize.src: W: spelling-error %description -l en_US SanitizeXSS ->
Sanitizes, Sanitize, Sanitarians
ghc-xss-sanitize.src: W: spelling-error %description -l en_US sanitizeXSS ->
sanitizes, sanitize, sanitarians
ghc-xss-sanitize.src: W: strange-permission xss-sanitize-0.2.2.tar.gz 0640L
ghc-xss-sanitize.src: W: strange-permission ghc-xss-sanitize.spec 0640L
ghc-xss-sanitize.x86_64: W: spelling-error Summary(en_US) untrusted ->
entrusted, untrustful, mistrusted
ghc-xss-sanitize.x86_64: W: spelling-error %description -l en_US untrusted ->
entrusted, untrustful, mistrusted
ghc-xss-sanitize.x86_64: W: spelling-error %description -l en_US SanitizeXSS ->
Sanitizes, Sanitize, Sanitarians
ghc-xss-sanitize.x86_64: W: spelling-error %description -l en_US sanitizeXSS ->
sanitizes, sanitize, sanitarians
ghc-xss-sanitize-devel.x86_64: W: spelling-error Summary(en_US) untrusted ->
entrusted, untrustful, mistrusted
ghc-xss-sanitize-devel.x86_64: W: spelling-error %description -l en_US
untrusted -> entrusted, untrustful, mistrusted
ghc-xss-sanitize-devel.x86_64: W: spelling-error %description -l en_US
SanitizeXSS -> Sanitizes, Sanitize, Sanitarians
ghc-xss-sanitize-devel.x86_64: W: spelling-error %description -l en_US
sanitizeXSS -> sanitizes, sanitize, sanitarians
ghc-xss-sanitize-prof.x86_64: E: devel-dependency ghc-xss-sanitize-devel
ghc-xss-sanitize-prof.x86_64: W: spelling-error Summary(en_US) untrusted ->
entrusted, untrustful, mistrusted
ghc-xss-sanitize-prof.x86_64: W: spelling-error %description -l en_US untrusted
-> entrusted, untrustful, mistrusted
ghc-xss-sanitize-prof.x86_64: W: spelling-error %description -l en_US
SanitizeXSS -> Sanitizes, Sanitize, Sanitarians
ghc-xss-sanitize-prof.x86_64: W: spelling-error %description -l en_US
sanitizeXSS -> sanitizes, sanitize, sanitarians
ghc-xss-sanitize-prof.x86_64: W: no-documentation
ghc-xss-sanitize-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/xss-sanitize-0.2.2/libHSxss-sanitize-0.2.2_p.a
4 packages and 0 specfiles checked; 1 errors, 20 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 8 months
[Bug 630206] New: Review Request: ghc-hledger-lib - Core types and utilities for working with hledger data
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ghc-hledger-lib - Core types and utilities for working with hledger data
https://bugzilla.redhat.com/show_bug.cgi?id=630206
Summary: Review Request: ghc-hledger-lib - Core types and
utilities for working with hledger data
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mathstuf(a)gmail.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec: http://benboeckel.net/packaging/ghc-hledger-lib/ghc-hledger-lib.spec
SRPM:
http://benboeckel.net/packaging/ghc-hledger-lib/ghc-hledger-lib-0.11.1-1....
Description:
This is the reusable core of the hledger financial app; use
it to build hledger and c++-ledger compatible finance tools.
% lintmock fedora-14-x86_64-bb
ghc-hledger-lib.src: W: strange-permission ghc-hledger-lib.spec 0640L
ghc-hledger-lib.src: W: strange-permission hledger-lib-0.11.1.tar.gz 0640L
ghc-hledger-lib-prof.x86_64: E: devel-dependency ghc-hledger-lib-devel
ghc-hledger-lib-prof.x86_64: W: no-documentation
ghc-hledger-lib-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/hledger-lib-0.11.1/libHShledger-lib-0.11.1_p.a
4 packages and 0 specfiles checked; 1 errors, 4 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 8 months