[Bug 553852] Review Request: pki-tps - The Dogtag PKI System Token Processing System
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=553852
--- Comment #12 from Parag AN(पराग) <panemade(a)gmail.com> 2010-02-03 05:20:06 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1960544
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
dc16095b91c96d7257328ce4b29423f173c25c9e pki-tps-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ initscripts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
Like Chris asked can we know how apache uses these conf files?
/usr/share/pki/tps/conf/CS.cfg
/usr/share/pki/tps/conf/httpd.conf
/usr/share/pki/tps/conf/nss.conf
/usr/share/pki/tps/conf/perl.conf
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 4 months