[Bug 457543] Review Request: perl-IPTables-Parse - A Perl extension for parsing iptables firewall rulesets
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457543
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2008-08-04 00:59:44 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=756386
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
03fcd2d010db1b7190f7e257124cb278 IPTables-Parse-0.6.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.01 cusr 0.00
csys = 0.01 CPU)
+ Package perl-IPTables-Parse-0.6-1.fc10 =>
Provides: perl(IPTables::Parse) = 0.5
Requires: perl >= 0:5.006 perl(Carp) perl(strict) perl(vars) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 9 months
[Bug 457509] Review Request: scim-thai - Thai IMEngine for SCIM
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457509
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2008-08-04 00:47:04 EDT ---
rpmlint gave me =>
scim-thai.i386: E: description-line-too-long Currently, it supports 3 keyboard
layouts: Ketmanee, TIS-820.2538, and Pattachote.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
scim-thai.i386: E: description-line-too-long In addition to keyboard layout
supports, it also validate input sequences in 3 levels of strictness:
Passthrough (no check), Basic Check, and Strict Check.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
scim-thai.i386: E: description-line-too-long For applications that support
surrounding text retrieval/deleting, it also corrects the invalid input
sequences.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 9 months
[Bug 457545] Review Request: perl-Net-Ping-External - Cross-platform interface to ICMP "ping" utilities
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457545
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2008-08-04 00:40:56 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756359
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
29c6cd74081861f4bffe1f83943f5792 Net-Ping-External-0.12.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package perl-Net-Ping-External-0.12-1.fc10 =>
Provides: perl(Net::Ping::External) = 0.12
Requires: perl(Carp) perl(Exporter) perl(Socket) perl(strict) perl(vars)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 9 months
[Bug 457546] Review Request: perl-Net-RawIP - A Perl extension for manipulating raw ip packets using libpcap
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457546
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade(a)gmail.com
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2008-08-04 00:36:14 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756354
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
f3b365136ccf88c79167ac3b1292e5b3 Net-RawIP-0.23.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=104, 4 wallclock secs ( 0.04 usr 0.01 sys + 4.38 cusr 0.08
csys = 4.51 CPU)
+ Package perl-Net-RawIP-0.23-1.fc10=>
Provides: RawIP.so perl(Net::RawIP) = 0.23 perl(Net::RawIP::ethhdr) = 0.23
perl(Net::RawIP::generichdr) = 0.23 perl(Net::RawIP::icmphdr) = 0.23
perl(Net::RawIP::iphdr) = 0.23 perl(Net::RawIP::opt) = 0.23
perl(Net::RawIP::tcphdr) = 0.23 perl(Net::RawIP::udphdr) = 0.23
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpcap.so.0.9 perl(AutoLoader)
perl(Carp) perl(Class::Struct) perl(DynaLoader) perl(English) perl(Exporter)
perl(Net::RawIP::ethhdr) perl(Net::RawIP::generichdr) perl(Net::RawIP::icmphdr)
perl(Net::RawIP::iphdr) perl(Net::RawIP::opt) perl(Net::RawIP::tcphdr)
perl(Net::RawIP::udphdr) perl(strict) perl(subs) perl(vars) perl(warnings)
rtld(GNU_HASH)
Suggestions:-
You can include examples directory in %doc.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 9 months
[Bug 450371] Review Request: pokegen - Strategy/RPG game engine
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450371
--- Comment #10 from mathstuf(a)gmail.com 2008-08-03 22:17:43 EDT ---
(In reply to comment #9)
> I just tried to rebuild your latest srpm but it failed as below.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=755698
This is due to the new position of the phonon libraries (they are no longer in
the KDE packages). I will update with my latest package which should be less
dependent on whether the latest Phonon is with Qt or KDE.
> Note:
> Please make build.log more verbose. The output like:
> ----------------------------------------------------------
> Building CXX object pokemod/CMakeFiles/pokemod.dir/MapTrainerTeamMember.o
> [ 9%]
> Building CXX object pokemod/CMakeFiles/pokemod.dir/MapWarp.o
> ----------------------------------------------------------
> is not useful. We want to check if Fedora compiler flags are correcly honored,
> for example.
I'm using the cmake_kde4 macro, which is what the KDE packaging uses. I'd
assume that the flags are set correctly there, but I will update it to use
CMAKE_VERBOSE_MAKEFILE.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 9 months