[Bug 188445] Review Request: bootconf
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: bootconf
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188445
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
QAContact|fedora-extras- |fedora-package-
|list(a)redhat.com |review(a)redhat.com
jpmahowald(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink(a)leemhuis.info |jpmahowald(a)gmail.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From jpmahowald(a)gmail.com 2006-04-18 14:03 EST -------
Locales need to be handled with %find_lang macro as per the guidelines on the wiki.
Missing URL, and Source0 is not a URL. If the source archive is publicly
available or it has a web page these should be added.
changelog is missing the version number, 1.0=1 in this case.
rpmlint is complaining that usermode is not required, yet it is for the base
package. You may want to move the Requires usermode to the gui subpackage for
clarity.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month
[Bug 186002] Review Request: python-archmod - Extensible reader/decompiler of files in CHM format
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-archmod - Extensible reader/decompiler of files in CHM format
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186002
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
QAContact|fedora-extras- |fedora-package-
|list(a)redhat.com |review(a)redhat.com
shahms(a)shahms.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink(a)leemhuis.info |shahms(a)shahms.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From shahms(a)shahms.com 2006-04-18 13:40 EST -------
Good:
- rpmlint gives no errors
- builds in mach just fine
- spec file and package name match (but see below)
- GPL license, license included, etc.
- md5sum matches upstream
- it meets the rest of the MUST clauses
The only "bad" thing I could find is that I don't think python-archmod is the
most appropriate name as the python module itself is secondary to the binary
functionality, if I'm not mistaken. It seems similar in this regard to bzr and
yum, and should be named appropriately.
Other than that, the package looks good.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years, 1 month