Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=452324
Summary: Review Request: lxterminal - Desktop-independent VTE- based terminal emulator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@christoph-wickert.de QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://cwickert.fedorapeople.org/review/lxterminal-0.1.2-1.fc10.src.rpm SRPM URL: http://cwickert.fedorapeople.org/review/lxterminal.spec Description: LXterminal is a VTE-based terminal emulator with support for multiple tabs. It is completely desktop-independent and does not have any unnecessary dependencies. In order to reduce memory usage and increase the performance all instances of the terminal are sharing a single process.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
mlichvar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mlichvar@redhat.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From fedora@christoph-wickert.de 2008-07-03 12:34 EST ------- Miroslav, please wait a moment, I'm going to upload 0.1.3.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From fedora@christoph-wickert.de 2008-07-03 12:37 EST ------- New SRPM: http://cwickert.fedorapeople.org/review/lxterminal-0.1.3-1.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
mlichvar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mlichvar@redhat.com 2008-07-03 13:35 EST ------- The spec file is cleanly written, everything seems good.
- rpmlint is silent - the package is named according to the Package Naming Guidelines - the spec file name matches the base package %{name} - the package meets the Packaging Guidelines - the package is licensed with a Fedora approved license - the License field in the package spec file matches the actual license (GPLv2+) - the package includes the text of the license in %doc - the spec file is written in American English - the spec file for the package is legible - the sources used to build the package matches the upstream source - the package successfully builds in x86_64 and ppc rawhide - all build dependencies are listed in BuildRequires - the spec file handles locales properly - the package owns all directories that it creates - the package does not contain any duplicate files in the %files listing - permissions on files are set properly - the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT - the package consistently uses macros - the package contains code, or permissible content - files included as %doc don't affect the runtime of the application - desktop file is installed with desktop-file-install - the package does not own files or directories already owned by other packages - at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT - all filenames in rpm packages are valid UTF-8 - the package functions as described (tested only on x86_64)
Approved.
The sed line in %prep can be removed, the typo was fixed in 0.1.3.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From fedora@christoph-wickert.de 2008-07-03 14:10 EST ------- (In reply to comment #3)
The sed line in %prep can be removed, the typo was fixed in 0.1.3.
Good catch (although I should have known that because I was the one who informed upstream about the typo). Will fix that after the import.
Thanks for the review!
New Package CVS Request ======================= Package Name: lxterminal Short Description: Desktop-independent VTE-based terminal emulator Owners: cwickert Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-07-04 16:14 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From updates@fedoraproject.org 2008-07-04 18:14 EST ------- lxterminal-0.1.3-1.fc9 has been submitted as an update for Fedora 9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From updates@fedoraproject.org 2008-07-04 18:15 EST ------- lxterminal-0.1.3-1.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From updates@fedoraproject.org 2008-07-06 02:12 EST ------- lxterminal-0.1.3-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From updates@fedoraproject.org 2008-07-06 02:17 EST ------- lxterminal-0.1.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxterminal - Desktop-independent VTE-based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=452324
------- Additional Comments From updates@fedoraproject.org 2008-07-26 01:56 EST ------- lxterminal-0.1.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452324
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #11 from Christoph Wickert fedora@christoph-wickert.de 2009-05-22 21:45:37 EDT --- Package Change Request ====================== Package Name: lxterminal New Branches: EL-4 EL-5 Owners: cwickert
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452324
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #12 from Kevin Fenzi kevin@tummy.com 2009-05-23 01:27:10 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452324
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |505781(LXDE)
package-review@lists.fedoraproject.org