https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Bug ID: 2116088 Summary: Review Request: rust-transpose - Utility for transposing multi-dimensional data Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: orion@nwra.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 2116087 Target Milestone: --- Classification: Fedora
Spec URL: https://orion.fedorapeople.org/rust-transpose.spec SRPM URL: https://orion.fedorapeople.org/rust-transpose-0.2.1-1.fc37.src.rpm Description: Utility for transposing multi-dimensional data.
Fedora Account System Username: orion
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2116087 [Bug 2116087] Review Request: rust-strength_reduce - Faster integer division and modulus operations
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2116092
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2116092 [Bug 2116092] Review Request: rust-rustfft - High-performance FFT library written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2063403
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2063403 [Bug 2063403] clamav-0.105.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2116088 Bug 2116088 depends on bug 2116087, which changed state.
Bug 2116087 Summary: Review Request: rust-strength_reduce - Faster integer division and modulus operations https://bugzilla.redhat.com/show_bug.cgi?id=2116087
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- There's some issues with the current version of this package:
1. upstream project does not include license files
You should file a PR with upstream to include LICENSE-APACHE and LICENSE-MIT files. Additionally, the link to the MIT license that you used points at an HTML page, not a plaintext version.
Please attempt to resolve this with upstream (i.e. "Copyright <YEAR> <COPYRIGHT HOLDER>" placeholder text also needs to be resolved somehow). I suspect the resolution will be similar to the one in the package for strength_reduce, given that it's the same upstream developer ...
2. drop criterion dependency entirely
The "criterion" library is only used in benchmark code. It is safe to remove it entirely from Fedora packages, since we neither build nor run benchmark code. Keeping the dependency usually just inflates the dependency tree and package build times by a huuuuuuge amount.
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Link ID| |Github | |ejmahler/transpose/pull/6
--- Comment #2 from Orion Poplawski orion@nwra.com --- Thanks. Similar license pull request submitted upstream.
Removed criterion. New files uploaded.
Spec URL: https://orion.fedorapeople.org/rust-transpose.spec SRPM URL: https://orion.fedorapeople.org/rust-transpose-0.2.1-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #3 from Fabio Valentini decathorpe@gmail.com ---
!! You still need to add the license files as %license in the -devel package's %files list. !! !! Other than that, looks good to me now, thanks. !!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files (standard license texts manually included; submitted PR to upstream) - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
--- Comment #4 from Orion Poplawski orion@nwra.com --- Upstream responded and added the license files.
Spec URL: https://orion.fedorapeople.org/rust-transpose.spec SRPM URL: https://orion.fedorapeople.org/rust-transpose-0.2.2-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-transpose
https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |rust-transpose-0.2.2-1.fc38 Resolution|--- |RAWHIDE Last Closed| |2022-11-09 15:04:44
--- Comment #6 from Orion Poplawski orion@nwra.com --- Checked in and built. Thanks all.
package-review@lists.fedoraproject.org