https://bugzilla.redhat.com/show_bug.cgi?id=824061
Bug ID: 824061 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: kevin@scrye.com Summary: Review Request: fcitx-unikey - Vietnamese Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuilong@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey.
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #1 from Liang Suilong liangsuilong@gmail.com --- (In reply to comment #0)
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey.
I post a wrong SRPM URL. Here is a correct URL.
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey.
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #2 from Kevin Fenzi kevin@scrye.com --- *** Bug 824063 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- Any particular reason you assigned this to me?
I can try and help review, but I'm pretty busy and likely won't get to it very soon...
https://bugzilla.redhat.com/show_bug.cgi?id=824061
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kevin@scrye.com |panemade@gmail.com Flags| |fedora-review?
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- Kevin, I will help the submitter with this package review like I did for his other fcitx-* package reviews. Taking this for review.
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- Review:-
+ Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915
+ rpmlint on rpms gave fcitx-unikey.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-unikey-0.1.0.tar.xz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. ==> This can be ignored
+ Source verified with upstream as (sha1sum) ef57f512d3ded16f6656be5e07e4465cbf13ffd5 fcitx-unikey-0.1.0.tar.xz ef57f512d3ded16f6656be5e07e4465cbf13ffd5 ../SOURCES/fcitx-unikey-0.1.0.tar.xz
Suggestions: 1) each pushd command should have corresponding popd. please add it in %build
2) I am not sure about final license tag. As ukengine part is in LGPLv2+, VnConv is in GPLv2+ and your own code is in GPLv3+.
Can you check with upstream? Guess you need to change your code from GPLv3+ to GPLv2+
3) The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use "%find_lang %{name}" at the end of %install section. See https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- I asked on #fedora-devel and come to know that without changing source license, this package can have license tag as GPLv3+
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #8 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- Can you please provide update here so that once package review completes and built in fedora, will be available for testing?
https://bugzilla.redhat.com/show_bug.cgi?id=824061
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(liangsuilong@gmai | |l.com)
--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- liangsuilong, If you are busy with your work then please allow me to fix this package and request SCM for this package and build it in Fedora so that people can use this.
https://bugzilla.redhat.com/show_bug.cgi?id=824061
Liang Suilong liangsuilong@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(liangsuilong@gmai | |l.com) |
--- Comment #11 from Liang Suilong liangsuilong@gmail.com --- SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4328977
https://bugzilla.redhat.com/show_bug.cgi?id=824061
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #12 from Parag AN(पराग) panemade@gmail.com --- It would have been good if you could have added some changelog and bumped the release tag for above change.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=824061
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(liangsuilong@gmai | |l.com)
--- Comment #13 from Parag AN(पराग) panemade@gmail.com --- Hi Liang, If you are busy, can I request you to allow me to import this package and co-own with you this package?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #14 from Parag AN(पराग) panemade@gmail.com --- No response from reporter since last 4 months here. If you still want this package in fedora then just reopen this and request for git package module. For now closing...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Flags|needinfo?(liangsuilong@gmai | |l.com) | Last Closed| |2012-12-10 22:16:23
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Liang Suilong liangsuilong@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- Keywords| |Reopened
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #15 from Liang Suilong liangsuilong@gmail.com --- New Package SCM Request ======================= Package Name: fcitx-unikey Short Description: Vietnamese Engine for Fcitx Owners: liangsuilong Branches: f16 f17 f18 el6 InitialCC: i18n-team
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Liang Suilong liangsuilong@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #16 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- fcitx-unikey-0.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fcitx-unikey-0.1.1-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- fcitx-unikey-0.1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-unikey-0.1.1-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- fcitx-unikey-0.1.1-2.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2012-12-10 22:16:23 |2012-12-27 22:52:02
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- fcitx-unikey-0.1.1-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- fcitx-unikey-0.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org