https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Bug ID: 1148702 Summary: Review Request: golang-github-bmizerany-pat - A Sinatra style pattern muxer for Go's net/http library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jchaloup@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-bmizerany-pat/golang... SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-bmizerany-pat/golang... Description: A Sinatra style pattern muxer for Go's net/http library Fedora Account System Username: jchaloup
Koji: package depends on Review Request: golang-github-bmizerany-assert, which is waiting for review. Locally it is build successfully.
$ rpmlint /root/rpmbuild/SRPMS/golang-github-bmizerany-pat-0-0.1.gitb8a3500.fc21.src.rpm /root/rpmbuild/RPMS/noarch/golang-github-bmizerany-pat-devel-0-0.1.gitb8a3500.fc21.noarch.rpm golang-github-bmizerany-pat.spec golang-github-bmizerany-pat.src: W: spelling-error Summary(en_US) muxer -> mixer, muter, mummer golang-github-bmizerany-pat.src: W: spelling-error Summary(en_US) http -> HTTP golang-github-bmizerany-pat.src: W: spelling-error %description -l en_US muxer -> mixer, muter, mummer golang-github-bmizerany-pat.src: W: spelling-error %description -l en_US http -> HTTP golang-github-bmizerany-pat-devel.noarch: W: spelling-error Summary(en_US) muxer -> mixer, muter, mummer golang-github-bmizerany-pat-devel.noarch: W: spelling-error Summary(en_US) http -> HTTP golang-github-bmizerany-pat-devel.noarch: W: spelling-error %description -l en_US muxer -> mixer, muter, mummer golang-github-bmizerany-pat-devel.noarch: W: spelling-error %description -l en_US http -> HTTP 2 packages and 1 specfiles checked; 0 errors, 8 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lsm5@fedoraproject.org Assignee|nobody@fedoraproject.org |lsm5@fedoraproject.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1148700 Flags|fedora-review? |fedora-review+
--- Comment #1 from Lokesh Mandvekar lsm5@fedoraproject.org --- Since we're not providing %{import_path}/example, do we want to even install the example dir in -devel? Don't know if other packages would need this as a BR.
Apart from that, specfile conforms to current Go packaging drafts.
Package approved
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1148700 [Bug 1148700] Review Request: golang-github-bmizerany-assert - Assertions for Go tests
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Jan Chaloupka jchaloup@redhat.com --- New Package SCM Request ======================= Package Name: golang-github-bmizerany-pat Short Description: A Sinatra style pattern muxer for Go's net/http library Upstream URL: https://github.com/bmizerany/pat Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-bmizerany-pat-0-0.1.gi...
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-bmizerany-pat-0-0.1.gi...
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-bmizerany-pat-0-0.1.gi...
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.el6 has been pushed to the Fedora EPEL 6 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.2.gitb8a3500.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-bmizerany-pat-0-0.2.gi...
https://bugzilla.redhat.com/show_bug.cgi?id=1148702 Bug 1148702 depends on bug 1148700, which changed state.
Bug 1148700 Summary: Review Request: golang-github-bmizerany-assert - Assertions for Go tests https://bugzilla.redhat.com/show_bug.cgi?id=1148700
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |golang-github-bmizerany-pat | |-0-0.1.gitb8a3500.fc20 Resolution|--- |ERRATA Last Closed| |2014-10-19 09:21:18
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-bmizerany-pat |golang-github-bmizerany-pat |-0-0.1.gitb8a3500.fc20 |-0-0.1.gitb8a3500.fc21
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.1.gitb8a3500.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1148702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-bmizerany-pat |golang-github-bmizerany-pat |-0-0.1.gitb8a3500.fc21 |-0-0.2.gitb8a3500.el6
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-bmizerany-pat-0-0.2.gitb8a3500.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org