Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Bug ID: 906843 Summary: Review Request: rubygem-qpid_proton - Ruby language bindings for the Qpid Proton messaging framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dpierce@redhat.com
Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.3-1.fc18.src.rpm Description: Ruby language bindings for the Qpid Proton messaging framework Fedora Account System Username: mcpierce
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- Taking.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- Well, * Current rawhide qpid_proton is 0.4 and BuildRequires dependency cannot be satisfied. Would you check this?
* Also the original gem file cannot be found on rubygems site.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #3 from Darryl L. Pierce dpierce@redhat.com --- (In reply to comment #2)
Well,
Current rawhide qpid_proton is 0.4 and BuildRequires dependency cannot be satisfied. Would you check this?
Also the original gem file cannot be found on rubygems site.
Proton 0.4 was voted on and released this week. I've rebased this package on that release:
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.4-1.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5067601
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #4 from Mamoru TASAKA mtasaka@fedoraproject.org --- For 0.4-1
* Version specific requires for ruby(release) - It seems that ruby(release) (Build)Requires should not have version specific dependency (see VÃt's comments: http://lists.fedoraproject.org/pipermail/ruby-sig/2013-February/001259.html )
* Installing native extension - The following line ------------------------------------------------------- mkdir -p %{buildroot}%{gem_extdir_mri}/ mv %{buildroot}%{gem_instdir}/lib/cproton.so \ %{buildroot}%{gem_extdir_mri}/lib ------------------------------------------------------- makes cproton.so _renamed_ to lib (i.e. the file "lib" is created with these lines).
* gem install - For gem install, please use %gem_install macro (note that on F-19, %gem_install used different option for documentation generation - on F-18/17, %gem_install also uses --rdoc option)
Currently "Installing native extension" item is really blocker.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #5 from Darryl L. Pierce dpierce@redhat.com --- (In reply to comment #4)
For 0.4-1
- Version specific requires for ruby(release)
- It seems that ruby(release) (Build)Requires should not have version specific dependency (see VÃt's comments:
http://lists.fedoraproject.org/pipermail/ruby-sig/2013-February/001259.html )
Fixed.
- Installing native extension
- The following line
mkdir -p %{buildroot}%{gem_extdir_mri}/ mv %{buildroot}%{gem_instdir}/lib/cproton.so \ %{buildroot}%{gem_extdir_mri}/lib
makes cproton.so _renamed_ to lib (i.e. the file "lib" is created with these lines).
Fixed. The specfile now ensures the directory exists, and then moves the shared library appropriately.
- gem install
- For gem install, please use %gem_install macro (note that on F-19, %gem_install used different option for documentation generation - on F-18/17, %gem_install also uses --rdoc option)
Currently "Installing native extension" item is really blocker.
Done.
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_proton-0.4-1.1.fc18.src.r... Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5070299
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Mamoru TASAKA mtasaka@fedoraproject.org --- For 0.4-1.1
* %gem_install usage - As written in /etc/rpm/macros.rubygems: --------------------------------------------------------- # Install gem into appropriate directory. # -n<gem_file> Overrides gem file name for installation. # -d<install_dir> Set installation directory. --------------------------------------------------------- and the default option is ./%{gem_dir}, and %{gem_name}-%{version}.gem for -n option. Note that to change gem_file and install_dir, explitit "-n" and "-d" is needed. For currently, for this package simply "%gem_install" is enough (and actually the following "%{gem_name}-%{version}.gem" is just ignored).
Other things are okay. -------------------------------------------------- This package (rubygem-qpid_proton) is APPROVED by mtasaka --------------------------------------------------
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Darryl L. Pierce dpierce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Darryl L. Pierce dpierce@redhat.com --- Thank you!
New Package SCM Request ======================= Package Name: rubygem-qpid_proton Short Description: Ruby language bindings for the Qpid Proton messaging framework Owners: mcpierce Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-qpid_proton-0.4-2.1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-qpid_proton-0.4-2.1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rubygem-qpid_proton-0.4-2.1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-qpid_proton-0.4-2.1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-qpid_proton-0.4-2.1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-03-08 01:51:18
--- Comment #12 from Mamoru TASAKA mtasaka@fedoraproject.org --- Closing.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-qpid_proton-0.4-2.1.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- rubygem-qpid_proton-0.4-2.1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=906843
Darryl L. Pierce dpierce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #15 from Darryl L. Pierce dpierce@redhat.com --- Package Change Request ====================== Package Name: rubygem-qpid_proton New Branches: epel7 Owners: mcpierce
https://bugzilla.redhat.com/show_bug.cgi?id=906843
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=906843
--- Comment #16 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org