Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: adpacifico@users.sourceforge.net QAContact: fedora-package-review@redhat.com
Spec URL: http://www.drizzle.com/~pacifico/perl-Class-Data-Accessor.spec SRPM URL: http://www.drizzle.com/~pacifico/perl-Class-Data-Accessor-0.03-1.src.rpm Description: Class::Data::Accessor is the marriage of Class::Accessor and Class::Data::Inheritable into a single module. It is used for creating accessors to class data that are overridable in subclasses as well as in class instances.
N.B. My second package review submission. I am looking for a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
adpacifico@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
------- Additional Comments From cweyl@alumni.drew.edu 2006-10-25 00:16 EST ------- Ok, so maybe it's just my machine is a little grumpy with me for upgrading to fc6, but with that source0 line spectool actually fetched a _symlink_. Filed at bug 212108.
Usually when there's both a Build.PL and Makefile.PL, Build.PL is the preferred mechanism to build the module. Not a blocker, however (and Makefile.PL is pretty much jsut a shell to Build.PL in this case anyways).
The spec is missing perl(Test::Pod) as a br for one of the tests... Add this and the package is be approved.
+ package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license (Build.PL) + license is open source-compatible. License text not included upstream. + source files match upstream: ebd99741ed0d65e95724ee72dae56bbe Class-Data-Accessor-0.03.tar.gz ebd99741ed0d65e95724ee72dae56bbe Class-Data-Accessor-0.03.tar.gz.srpm + latest version is being packaged. X BuildRequires are proper. + rpmlint is silent. + final provides and requires are sane: ** perl-Class-Data-Accessor-0.03-1.fc5.noarch.rpm == rpmlint == provides perl(Class::Data::Accessor) = 0.03 perl-Class-Data-Accessor = 0.03-1.fc5 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(strict) perl(vars) + no shared libraries are present. + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + %check is present and all tests pass: All tests successful. Files=3, Tests=21, 0 wallclock secs ( 0.18 cusr + 0.09 csys = 0.27 CPU) + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. + not a web app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
------- Additional Comments From cweyl@alumni.drew.edu 2006-10-25 00:22 EST ------- One additional thing I should have noted.... With noarch perl packages, it's possible to trim the OPTIMIZE="$RPM_OPT_FLAGS" being passed in %build, and to remove the entire "find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'" line from %install. This is not a blocker, but rather just a matter of eliminating parts of the spec template that are not needed for noarch perl packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
------- Additional Comments From tibbs@math.uh.edu 2007-06-01 22:55 EST ------- Well, it's been more than half a year since the last comment. Is anything happening here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-Data-Accessor - CPAN module aids OO development for perl classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211737
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NOTABUG OtherBugsDependingO|163778, 177841 | nThis| |
------- Additional Comments From tibbs@math.uh.edu 2007-06-09 23:33 EST ------- I guess now; closing.
package-review@lists.fedoraproject.org