Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
Summary: Review Request: python-pydns - Another Pyhon DNS library. Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jafo-redhat@tummy.com QAContact: fedora-package-review@redhat.com
Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-1.noarch.rpm Description: Another Python DNS library, this one is based on Guido's original code, updated by Anthony Baxter. It is required for the PySPF package.
This is my first package and I need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |204561 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: python-pydns|Review Request: python-pydns |- Another Pyhon DNS library.|- Another Pyhon DNS library. Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@tummy.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From kevin@tummy.com 2006-08-29 22:48 EST ------- I'd be happy to take a look at this (and pyspf).
Your SRPM link seems to be pointing to the noarch instead of the src.rpm... can you provide an updated link? :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From kevin@tummy.com 2006-08-29 23:18 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - Package compiles and builds on at least one arch. OK - BuildRequires correct See below - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock.
Issues:
1. Should the license really be "Python Software Foundation License" and not "Python license" ? a grep in the unpacked source gives: PKG-INFO:License: Python license README.txt:This code is released under a Python-style license. setup.py: license = 'Python license',
2. You should provide a full path to the source in Source0. Perhaps something like: Source0: http://easynews.dl.sourceforge.net/sourceforge/pydns/ pydns-%{version}.tgz
3. You need to own the %{python_sitelib}/DNS/ directory, not just it's contents.
4. rpmlint says: W: python-pydns summary-ended-with-dot Python module for DNS (Domain Name Service). Suggest: remove the . at the end of the summary line.
5. You BuildRequire python-setuptools, according to the python package guidelines ( at http://fedoraproject.org/wiki/Packaging/Python ), "Python packages that use setuptools need to add python-setuptools as a BuildRequires and must either add --single-version-externally-managed to the line invoking setup.py in %install, or must add a .pth file containing the path to the egg or egg directory to %{python_sitelib}." Should this package do that? Or does it really need python-setuptools at all?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From jafo-redhat@tummy.com 2006-08-30 05:47 EST ------- Sorry about that. Here's the SRPM:
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From jafo-redhat@tummy.com 2006-08-30 06:06 EST ------- Thanks for the pointers, Kevin.
Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From kevin@tummy.com 2006-08-30 22:23 EST ------- ok, all the 5 issues above from comment #2 are fixed... one new thing however, you're missing a changelog entry for the -2 release.
Fix that up and I think this will be all ready for approval.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From jafo-redhat@tummy.com 2006-08-31 02:09 EST ------- I've changed this to include a changelog for -3. I hope this is ok, as I pretty much consider everything <-3 to be part of the initial packaging, since I haven't released them otherwise.
Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From jafo-redhat@tummy.com 2006-08-31 17:31 EST ------- This version has changelog entries for the -2
Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns.spec SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pydns-2.3.0-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From kevin@tummy.com 2006-08-31 21:17 EST ------- looks good. This package is APPROVED.
I'd be happy to sponsor you...
Continue the process from the "get a fedora account" section on: http://www.fedoraproject.org/wiki/Extras/Contributors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
jafo-redhat@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From jafo-redhat@tummy.com 2006-09-01 15:10 EST ------- The package was imported and built.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
jafo@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From jafo@tummy.com 2007-06-11 19:33 EST ------- Package Change Request ====================== Package Name: python-pydns New Branches: EL-5
To get into EPEL.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-06-11 19:43 EST ------- branch done.
package-review@lists.fedoraproject.org