https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Bug ID: 1964694 Summary: Review Request: rust-femme - Pretty-printer and ndjson logger for log crate Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-femme.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-femme-2.1.1-1.fc34.src.rpm
Description: Not just a pretty (inter)face: pretty-printer and ndjson logger for log crate.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |o.lemasle@gmail.com Assignee|nobody@fedoraproject.org |o.lemasle@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #2 from Olivier Lemasle o.lemasle@gmail.com --- As the two PNG files (pretty.png and ndjson.png) are referenced in README.md, shouldn't they be in %doc too?
Files list:
/usr/share/cargo/registry/femme-2.1.1/.cargo-checksum.json /usr/share/cargo/registry/femme-2.1.1/Cargo.toml /usr/share/cargo/registry/femme-2.1.1/LICENSE-APACHE /usr/share/cargo/registry/femme-2.1.1/LICENSE-MIT /usr/share/cargo/registry/femme-2.1.1/README.md /usr/share/cargo/registry/femme-2.1.1/examples/log.rs /usr/share/cargo/registry/femme-2.1.1/examples/million.rs /usr/share/cargo/registry/femme-2.1.1/ndjson.png <----- /usr/share/cargo/registry/femme-2.1.1/pretty.png <----- /usr/share/cargo/registry/femme-2.1.1/src/lib.rs /usr/share/cargo/registry/femme-2.1.1/src/ndjson.rs /usr/share/cargo/registry/femme-2.1.1/src/pretty.rs /usr/share/cargo/registry/femme-2.1.1/src/wasm.rs /usr/share/doc/rust-femme-devel/README.md /usr/share/licenses/rust-femme-devel/LICENSE-APACHE /usr/share/licenses/rust-femme-devel/LICENSE-MIT
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Hm. Not sure they add any value, since I guess nobody would look at /usr/share/doc/rust-femme-devel/README.md with an editor that supports HTML preview for markdown files ... and if anybody wants to, these files *and* the README are still included in the crate sources directly.
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Olivier Lemasle o.lemasle@gmail.com --- Ok.
- Licenses OK - Conforms to packaging guidelines - builds in mock - no rpmlint error - latest version packaged
Package approved
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/34258 https://pagure.io/releng/fedora-scm-requests/issue/34259
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-femme
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-e9ef597214 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e9ef597214 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1964694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-06-04 01:12:56
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org