https://bugzilla.redhat.com/show_bug.cgi?id=1030968
Bug ID: 1030968 Summary: Review Request: python-micawber - Python library for extracting rich content from URLs Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cickumqt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://cicku.me/python-micawber.spec SRPM URL: http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm Description: micawber is a small library for extracting rich content from URLs. It supplies a few methods for retrieving rich metadata about a variety of links, such as links to youtube videos. micawber also provides functions for parsing blocks of text and html and replacing links to videos with rich embedded content. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1010741
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 [Bug 1010741] python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@gmail.co | |m Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Flags| |fedora-review?
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6190605
$ rpmlint -i -v *python3-micawber.noarch: I: checking python3-micawber.noarch: W: spelling-error Summary(en_US) urls -> curls, purls, hurls The value of this tag appears to be misspelled. Please double-check.
python3-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal The value of this tag appears to be misspelled. Please double-check.
python3-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube The value of this tag appears to be misspelled. Please double-check.
python3-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml The value of this tag appears to be misspelled. Please double-check.
python3-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds) python3-micawber.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/models.py python-micawber.noarch: I: checking python-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal The value of this tag appears to be misspelled. Please double-check.
python-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube The value of this tag appears to be misspelled. Please double-check.
python-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml The value of this tag appears to be misspelled. Please double-check.
python-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds) python-micawber.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/models.py python-micawber.src: I: checking python-micawber.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal The value of this tag appears to be misspelled. Please double-check.
python-micawber.src: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube The value of this tag appears to be misspelled. Please double-check.
python-micawber.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml The value of this tag appears to be misspelled. Please double-check.
python-micawber.src: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds) python-micawber.src:56: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:56: W: macro-in-comment %{python_sitelib} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:56: W: macro-in-comment %{__python2} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:57: W: macro-in-comment %{py3dir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:58: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:58: W: macro-in-comment %{python_sitelib} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src:58: W: macro-in-comment %{__python3} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.src: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds) python-micawber.spec:56: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:56: W: macro-in-comment %{python_sitelib} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:56: W: macro-in-comment %{__python2} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:57: W: macro-in-comment %{py3dir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:58: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:58: W: macro-in-comment %{python_sitelib} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec:58: W: macro-in-comment %{__python3} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate.
python-micawber.spec: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 6 errors, 24 warnings.
Please fix the file headers. We don't use the "env" style anymore, and scripts in %{python?_sitelib} don't use shebangs at all.
Escape the macros in the comments in the %check section to avoid unexpected behavior.
"urls" is a terrible construct. Use "URLs" instead.
Have a look at the test scripts. I don't assume that we really need empty files, unless they serve as placeholders for something. Otherwise, remove them.
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC|mario.blaettermann@gmail.co | |m | Assignee|mario.blaettermann@gmail.co |nobody@fedoraproject.org |m | Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
Sachidananda Urs surs@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |surs@redhat.com Assignee|nobody@fedoraproject.org |surs@redhat.com Flags| |fedora-review?
--- Comment #2 from Sachidananda Urs surs@redhat.com --- This is un-official review of the package:
https://bugzilla.redhat.com/show_bug.cgi?id=1030968
--- Comment #3 from Sachidananda Urs surs@redhat.com --- I'm not able to find the SRPM, the link is broken.
fedora-review -b 1030968 INFO: Processing bugzilla bug: 1030968 INFO: Getting .spec and .srpm Urls from : 1030968 INFO: --> SRPM url: http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm INFO: --> Spec url: http://cicku.me/python-micawber.spec INFO: Using review directory: /tmp/1030968-python-micawber INFO: Downloading .spec and .srpm files ERROR: 'Error 404 downloading http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm' (logs in /home/sac/.cache/fedora-review.log)
package-review@lists.fedoraproject.org