Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-unidecode - US-ASCII transliterations of Unicode text
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Summary: Review Request: python-unidecode - US-ASCII transliterations of Unicode text Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pj.pandit@yahoo.co.in QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://pjp.dgplug.org/tools/python-unidecode.spec SRPM URL: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-1.fc14.src.rpm
Description: <description here> It often happens that you have non-Roman text data in Unicode, but you can't display it -- usually because you're trying to show it to a user via an application that doesn't support Unicode, or because the fonts you need aren't accessible. You could represent the Unicode characters as "???????" or " BA A0q0...", but that's nearly useless to the user who actually wants to read what the text says.
What Unidecode provides is a function, 'unidecode(...)' that takes Unicode data and tries to represent it in ASCII characters (i.e., the universally displayable characters between 0x00 and 0x7F). The representation is almost always an attempt at transliteration -- i.e., conveying, in Roman letters, the pronunciation expressed by the text in some other writing system.
For example 'unidecode(u"u5317u4EB0")' returns 'Bei Jing'.
This is a Python port of Text::Unidecode Perl module by Sean M. Burke.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com
--- Comment #1 from Rahul Sundaram metherid@gmail.com 2011-07-11 20:09:36 EDT ---
Run a mock build or koji scratch build. In particular, you need
BuildRequires: python-devel BuildRequires: python-setuptools
Remove any commented out lines.
Use name and version macro for Source0
Contact upstream and ask them to include a copy of the licenses. Especially GPL requires this. Include any licenses in %doc
Description can be shortened to:
This is a python port of Text::Unidecode Perl module. It provides a function, 'unidecode(...)' that takes unicode data and tries to represent it in ASCII characters. For example, 'unidecode(u"u5317u4EB0")' returns 'Bei Jing'.
%defattr(-,root,root,-) is redundant. You don't need this anymore.
Might consider moving %doc to be right after %files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |metherid@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
--- Comment #2 from pjp pj.pandit@yahoo.co.in 2011-07-12 13:32:42 EDT --- I've made the changes. Please see the files below:
SPEC: http://pjp.dgplug.org/tools/python-unidecode.spec SRPM: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-2.fc14.src.rpm
Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
--- Comment #3 from Rahul Sundaram metherid@gmail.com 2011-07-12 17:45:54 EDT ---
Use srcname and version macro in
Source0: http://pypi.python.org/packages/source/U/Unidecode/Unidecode-0.04.7.tar.gz
Change URL to http://pypi.python.org/pypi/%%7Bsrcname%7D/
Redundant "is" in second statement in description. Drop that. Upstream should include a copy of the license(s) and then I can approve this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
--- Comment #4 from pjp pj.pandit@yahoo.co.in 2011-07-15 10:50:19 EDT --- I've made the changes. Please see:
SPEC: http://pjp.dgplug.org/tools/python-unidecode.spec SRPM: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-3.fc14.src.rpm
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3201515
Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+
--- Comment #5 from Rahul Sundaram metherid@gmail.com 2011-07-15 10:55:45 EDT ---
Looks good. Make sure you branch for EPEL 6
==== APPROVED ====
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
pjp pj.pandit@yahoo.co.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from pjp pj.pandit@yahoo.co.in 2011-07-15 14:28:30 EDT --- New Package SCM Request ======================= Package Name: unidecode Short Description: Python module for US-ASCII transliterations of Unicode text. Owners: pjp Branches: f14 f15 fl6 epel-6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-07-15 14:37:38 EDT --- Is this to be python-unidecode or unidecode? Also, remove fl6 and replace epel-6 with EL-6.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Rahul Sundaram metherid@gmail.com 2011-07-15 21:37:01 EDT --- New Package SCM Request ======================= Package Name: python-unidecode Short Description: Python module for US-ASCII transliterations of Unicode text. Owners: pjp sundaram Branches: f15 el-6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-07-15 22:15:58 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-07-16 03:38:09
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED CC| |ville.skytta@iki.fi Resolution|RAWHIDE | Keywords| |Reopened
--- Comment #10 from Ville Skyttä ville.skytta@iki.fi 2011-07-17 16:57:59 EDT --- Is there a reason this package is not noarch? It doesn't seem to contain anything arch specific.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |496968(DebugInfo)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed|2011-07-16 03:38:09 |2011-07-18 00:45:44
--- Comment #11 from Rahul Sundaram metherid@gmail.com 2011-07-18 00:45:44 EDT ---
Fixed. Credited in changelog
package-review@lists.fedoraproject.org