https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Bug ID: 1709481 Summary: Review Request: vim-ctrlp - Full path fuzzy file, buffer, mru, tag, ... finder for Vim Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: osoukup@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/osoukup/ctrlp.vim/fedora-raw... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/osoukup/ctrlp.vim/fedora-raw... Description:
Hi anyone! I am enthusiastic VIM user and I really like vim.ctrlp plugin which adds awesome easy-to-use but powerful search capabilities. You can find upstream repo at
https://github.com/ctrlpvim/ctrlp.vim
After some time of using it I think that it might be nice to have it as official Fedora package the same way as some other great VIM plugins are. I prepared everything I found out is necessary and now would be very glad for some review. I am new to Fedora packaging so I appreciate any advice or help.
For the sake of completeness here are the links to COPR project and KOJI scratch build
https://copr.fedorainfracloud.org/coprs/osoukup/ctrlp.vim/ https://koji.fedoraproject.org/koji/taskinfo?taskID=34834617
For the testing purposes I have created personal public repo where anyone can find scripts to easily test the RPM build and install in Vagrant with libvirt VM
https://github.com/osoukup/ctrlp.vim
Fedora Account System Username: osoukup@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Ondrej Soukup osoukup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #1 from Ondrej Soukup osoukup@redhat.com --- Adding also rpmlint reports:
---------------------
$ rpmlint -i SRPMS/vim-ctrlp-1.8.0-1.fc30.src.rpm vim-ctrlp.src: W: spelling-error Summary(en_US) mru -> mu, rum The value of this tag appears to be misspelled. Please double-check.
vim-ctrlp.src: W: spelling-error %description -l en_US mru -> mu, rum The value of this tag appears to be misspelled. Please double-check.
vim-ctrlp.src: W: spelling-error %description -l en_US gVim -> g Vim, grim, vim The value of this tag appears to be misspelled. Please double-check.
vim-ctrlp.src: W: invalid-url Source0: vim-ctrlp-1.8.0.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
---------------------
$ rpmlint -i RPMS/noarch/vim-ctrlp-1.8.0-1.fc30.noarch.rpm vim-ctrlp.noarch: W: spelling-error Summary(en_US) mru -> mu, rum The value of this tag appears to be misspelled. Please double-check.
vim-ctrlp.noarch: W: spelling-error %description -l en_US mru -> mu, rum The value of this tag appears to be misspelled. Please double-check.
vim-ctrlp.noarch: W: spelling-error %description -l en_US gVim -> g Vim, grim, vim The value of this tag appears to be misspelled. Please double-check.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
---------------------
That mru spelling error in the description should IMO refer to most recently used which is correct abbreviation. The description was however taken unchanged from the upstream:
http://ctrlpvim.github.io/ctrlp.vim/
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Source0 must be a url pointing to the archive
Source0: https://github.com/ctrlpvim/ctrlp.vim/archive/%%7Bversion%7D/%%7Bname%7D-%%7...
- Version is 1.80, not 1.8.0
- Appdata dir is the obsolete location, Appdata files now go in %{_metainfodir}
- Add vim-filesystem as a RR too
Requires: vim-filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #3 from Ondrej Soukup osoukup@redhat.com --- Thank you very much for the review!
(In reply to Robert-André Mauchin from comment #2)
- Source0 must be a url pointing to the archive
Source0: https://github.com/ctrlpvim/ctrlp.vim/archive/%%7Bversion%7D/%%7Bname%7D-%%7.... tar.gz
I updated Source0 and also Source1 (hope I am not too eager) to URLs instead of file system paths.
- Version is 1.80, not 1.8.0
I corrected the version number. I have to admit that I was confused by the upstream since they use to use X.Y.Z versions but switched to X.YZ for some reason. You are right that I should respect their version notation.
- Appdata dir is the obsolete location, Appdata files now go in
%{_metainfodir}
Directory for appdata files was also corrected according to your suggestion.
- Add vim-filesystem as a RR too
Requires: vim-filesystem
The requirements were updated also.
The complete list of changes is at
https://copr-dist-git.fedorainfracloud.org/cgit/osoukup/ctrlp.vim/vim-ctrlp....
Additionally follows the links to updated COPR and KOJI builds
https://copr.fedorainfracloud.org/coprs/osoukup/ctrlp.vim/build/929280/ https://koji.fedoraproject.org/koji/taskinfo?taskID=35450870
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #4 from Ondrej Soukup osoukup@redhat.com --- Additionally the following warning is no more produced by rpmlint:
vim-ctrlp.src: W: invalid-url Source0: vim-ctrlp-1.8.0.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- - Why -c? This break the build
%setup -cq
Use:
%autosetup -n ctrlp.vim-%{version}
- There's no LICENSE file in the archive.
+ cp -pr LICENSE /builddir/build/BUILDROOT/vim-ctrlp-1.80-1.fc31.x86_64/usr/share/licenses/vim-ctrlp BUILDSTDERR: cp: cannot stat 'LICENSE': No such file or directory + : + exit 0 BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/vim-ctrlp-1.80-1.fc31.x86_64/usr/share/licenses/vim-ctrlp/LICENSE
Add it as another source from GH or consider packaging a snapshot version of the master branch.
%global commit 2e773fd8c7548526853fff6ee2e642eafbbe3d04 %global shortcommit %(c=%%{commit}; echo ${c:0:7}) %global snapshotdate 20190610
Name: vim-ctrlp Version: 1.80 Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} Summary: Full path fuzzy file, buffer, mru, tag, ... finder for Vim
License: Vim URL: https://github.com/ctrlpvim/ctrlp.vim Source0: https://github.com/ctrlpvim/ctrlp.vim/archive/%%7Bcommit%7D/%%7Bname%7D-%%7B...
[…]
%autosetup -n ctrlp.vim-%{commit}
[…]
* Tue Feb 26 2019 Ondřej Soukup osoukup@redhat.com - 1.80-1.20190610git2e773fd
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |i.gnatenko.brain@gmail.com Assignee|nobody@fedoraproject.org |i.gnatenko.brain@gmail.com
--- Comment #6 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Hey Ondrej,
I sponsored you to the packagers group.
Let me know if you need any assistance with review made by eclipseo.
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #7 from Ondrej Soukup osoukup@redhat.com --- (In reply to Igor Gnatenko from comment #6)
Hey Ondrej,
I sponsored you to the packagers group.
Let me know if you need any assistance with review made by eclipseo.
Thank you very much Igor! I am also thankful to Robert-André for his reviews. After his last comment I tried to incorporate his suggestions in various ways but I am still just struggling with it without any success. I at least understood some of my previous mistakes like building from my own modified archive instead of the upstream one.
I was first trying to stick with version-directed approach which I was using previously. The farthest I got was to various LICENSE install errors and got stuck with it. I am not sure how to install it. I was not able to find some example or documentation which would work for me.
Now I am investigating the second suggested commit-oriented approach. Simple copy-pasting ended up with invalid spec file so now I am learning it and trying to solve what is the correct working way of using it.
I am doing this my little packaging adventure in my free time and cannot find more than couple of hours for it every week so I am proceeding quite slowly. Moreover, I feel most of my last tries ended up as a waste of time investigating blind ways.
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #8 from Ondrej Soukup osoukup@redhat.com --- So as soon as I wrote down all these despair here things finally moved forward! I used commit-based approach as suggested by Robert-André - thank you - which works like a charm. I just had to first find out an unrelated typo of mine which made me think it does not work so straightforward...
Here are the changes
https://github.com/osoukup/ctrlp.vim/commit/2afc0feca05dbf86d4fc233b34951056...
and here are the new builds
https://copr.fedorainfracloud.org/coprs/osoukup/ctrlp.vim/build/944205/ https://koji.fedoraproject.org/koji/taskinfo?taskID=35793933
Thank you both once again!
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Assignee|i.gnatenko.brain@gmail.com |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #9 from Robert-André Mauchin zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #10 from Ondrej Soukup osoukup@redhat.com --- (In reply to Robert-André Mauchin from comment #9)
LGTM, package approved.
Thank you for the detailed review and lot of advice!
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vim-ctrlp
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-11d543f05f has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-11d543f05f
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- vim-ctrlp-1.80-1.20190610git2e773fd.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-11d543f05f
https://bugzilla.redhat.com/show_bug.cgi?id=1709481
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-08-09 01:02:43
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- vim-ctrlp-1.80-1.20190610git2e773fd.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org