https://bugzilla.redhat.com/show_bug.cgi?id=1016947
Bug ID: 1016947 Summary: Review Request: python-iscpy - Python library to parse ISC style config files Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: yohangraterol92@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
python-iscpy
Python library to parse ISC style config files
SPEC: http://yograterol.fedorapeople.org/python-iscpy.spec SRPM: http://yograterol.fedorapeople.org/python-iscpy-1.05-1.fc19.src.rpm
FAS User: yograterol
https://bugzilla.redhat.com/show_bug.cgi?id=1016947
Eduardo Echeverria echevemaster@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@gmail.com
--- Comment #1 from Eduardo Echeverria echevemaster@gmail.com --- rpmlint -v python-iscpy-1.05-1.fc20.noarch.rpm python-iscpy.noarch: I: checking ****** python-iscpy.noarch: I: checking-url https://pypi.python.org/pypi/iscpy (timeout 10 seconds) python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/iscpy_dns/named_importer_lib.py 0644L /usr/bin/env python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/iscpy_core/core.py 0644L /usr/bin/env python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/__init__.py 0644L /usr/bin/python 1 packages and 0 specfiles checked; 3 errors, 2 warnings.
Please change shebang for invoking the default interpreter, and take care of the permissions
I can't see any test on the build phase + cd iscpy-1.05 ++ pwd + PYTHONPATH=/builddir/build/BUILD/iscpy-1.05 + /usr/bin/python setup.py test running test + exit 0
Seems that not there any explicit requires ➜ iscpy-1.05 ls -la | grep -ri "import" iscpy/iscpy_core/core.py:import copy iscpy/iscpy_core/core.py:import cPickle iscpy/iscpy_dns/named_importer_lib.py:import copy iscpy/iscpy_dns/named_importer_lib.py:import iscpy iscpy/__init__.py:from iscpy_core.core import * iscpy/__init__.py:import iscpy_dns.named_importer_lib as dns test/named_importer_lib_regtest.py:import unittest test/named_importer_lib_regtest.py:import os test/named_importer_lib_regtest.py:import iscpy test/named_importer_lib_regtest.py:class TestNamedImport(unittest.TestCase): test/blank_named_regtest.py:import unittest test/blank_named_regtest.py:import os test/blank_named_regtest.py:import iscpy test/blank_named_regtest.py:class TestNamedImport(unittest.TestCase): ez_setup/__init__.py: from ez_setup import use_setuptools ez_setup/__init__.py:import sys ez_setup/__init__.py:import sys, os ez_setup/__init__.py:try: from hashlib import md5 ez_setup/__init__.py:except ImportError: from md5 import md5 ez_setup/__init__.py: was_imported = 'pkg_resources' in sys.modules or 'setuptools' in sys.modules ez_setup/__init__.py: import setuptools; setuptools.bootstrap_install_from = egg ez_setup/__init__.py: import pkg_resources ez_setup/__init__.py: except ImportError: ez_setup/__init__.py: if was_imported: ez_setup/__init__.py: import urllib2, shutil ez_setup/__init__.py: from distutils import log ez_setup/__init__.py: ); from time import sleep; sleep(delay) ez_setup/__init__.py: import setuptools ez_setup/__init__.py: except ImportError: ez_setup/__init__.py: from setuptools.command.easy_install import main ez_setup/__init__.py: import pkg_resources ez_setup/__init__.py: from setuptools.command.easy_install import main ez_setup/__init__.py: except ImportError: ez_setup/__init__.py: from easy_install import main ez_setup/__init__.py: from setuptools.command.easy_install import main ez_setup/__init__.py: import re ez_setup/__init__.py: import inspect iscpy.egg-info/SOURCES.txt:iscpy/iscpy_dns/named_importer_lib.py iscpy.egg-info/SOURCES.txt:test/named_importer_lib_regtest.py setup.py: from setuptools import setup, find_packages setup.py:except ImportError: setup.py: from ez_setup import use_setuptools setup.py: from setuptools import setup, find_packages setup.py:import sys, os MANIFEST:iscpy/iscpy_dns/named_importer_lib.py
Please fix the issues, and I will do the review,
https://bugzilla.redhat.com/show_bug.cgi?id=1016947
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@gmail.com
--- Comment #2 from William Moreno williamjmorenor@gmail.com --- Any update here?
Can I take the review?
https://bugzilla.redhat.com/show_bug.cgi?id=1016947
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yohangraterol92@gmail.com Flags| |needinfo?(yohangraterol92@g | |mail.com)
--- Comment #3 from William Moreno williamjmorenor@gmail.com --- Hi, do want to continue with this review?
https://bugzilla.redhat.com/show_bug.cgi?id=1016947
Gwyn Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |limburgher@gmail.com Resolution|--- |NOTABUG Last Closed| |2017-05-23 09:44:53
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- Doesn't build, please reopen if still interested in this package.
package-review@lists.fedoraproject.org