Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
Summary: Review Request: professor-is-missing - An AGI adventure game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: limb@jcomserv.net QAContact: fedora-package-review@redhat.com
Spec URL: http://zanoni.jcomserv.net/fedora/professor-is-missing.spec SRPM URL: http://zanoni.jcomserv.net/fedora/professor-is-missing-0.1-1.src.rpm Description: In this little game, for a mysterious reason, the Professor is disaspeared in Africa. As Eric, you must find a way to go to Africa to find out the
For background on licensing and 0-length file issues, see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240195
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From musuruan@gmail.com 2007-05-30 10:33 EST ------- 404: files not found.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From limb@jcomserv.net 2007-05-30 11:12 EST ------- Whoops. :)
Spec URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing.... SRPM URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From limb@jcomserv.net 2007-05-30 13:36 EST ------- Fixed ridiculous .desktop typo: Spec URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing.... SRPM URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From tibbs@math.uh.edu 2007-06-04 21:01 EST ------- I don't think it's a good idea to make any modifications to the upstream tarball (or zipfile in this case) other than the removal of the nondistributable content. The downcasing of filenames and line ending conversion can easily be done in %prep.
This makes a comparison easy: just unzip both the modified and pristine files and run a recursive diff. They should differ only in that some files have been removed. As it is, any comparison is difficult.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From limb@jcomserv.net 2007-06-06 08:39 EST ------- Corrected, but done in %setup, not %prep.
Spec URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing.... SRPM URL: http://zanoni.jcomserv.net/fedora/professor-is-missing/professor-is-missing-...
Been following the thread on f-p. I agree that the more pristine the tarball can be, the better.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
------- Additional Comments From tibbs@math.uh.edu 2007-06-08 20:38 EST ------- Actually you are doing it in %prep. %prep is a section; %setup is a macro.
I'll take a look.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2007-06-08 22:05 EST ------- rpmlint says just: E: professor-is-missing zero-length /usr/share/professor-is-missing/snddir My understanding is that this empty directory is necessary for nagi, else it segfaults. Which would be a bug perhaps worth fixing, but probably shouldn't hold up AGI packages.
BTW, you can downcase a bunch of filenames with something like for i in *; do j=`echo $i|tr '[A-Z]' '[a-z]'` if [ $i != $j ]; then mv $i $j fi done
* source files match upstream. Manually compared exploded Source0 with the upsteam zipfile: Only in upstream: Agi Only in upstream: AGIDATA.OVL Only in upstream: CGA_GRAF.OVL Only in upstream: EGA_GRAF.OVL Only in upstream: HGC_FONT Only in upstream: HGC_GRAF.OVL Only in upstream: HGC_OBJS.OVL Only in upstream: IBM_OBJS.OVL Only in upstream: JR_GRAF.OVL Only in upstream: prof.com Only in upstream: VG_GRAF.OVL * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is acceptable for content in Fedora. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only unavoidable complaints. * final provides and requires are sane: professor-is-missing = 0.1-3.fc8 = /bin/bash /bin/sh hicolor-icon-theme nagi * %check is not present; no test suite. I played for a few minutes and managed no score no points at all. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * contains acceptable content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop file looks OK and is installed properly.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From limb@jcomserv.net 2007-06-09 23:59 EST ------- New Package CVS Request ======================= Package Name: professor-is-missing Short Description: An AGI adventure game Owners: limb@jcomserv.net Branches: FC_5 FC-6 F-7 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-10 02:14 EST ------- BTW, you forgot to set the fedora-cvs flag. Fortunately I have CVS admin privs so I can take care of this.
CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From limb@jcomserv.net 2007-06-11 07:44 EST ------- Man, it's been one of those weeks. Good catch.
Built in devel. Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
------- Additional Comments From updates@fedoraproject.org 2007-06-11 18:06 EST ------- professor-is-missing-0.1-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: professor-is-missing - An AGI adventure game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241761
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.1-3.fc7
package-review@lists.fedoraproject.org