Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: scannotation - A Java annotation scanner
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Summary: Review Request: scannotation - A Java annotation scanner Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kchamart@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
SPEC: http://10.65.201.157/rpmbuild/SPECS/scannotation.spec
SRPM: http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.1.r12.fc17.src.r...
Description:
Scannotation is a Java library that creates an annotation database from a set of .class files.This database is really just a set of maps that index what annotations are used and what classes are using them. Why do you need this? What if you are an annotation framework like an EJB 3.0 container and you want to automatically scan your classpath for EJB annotations so that you know what to deploy? Scannotation gives you apis that allow you to find archives in your classpath or WAR (web application) that you want to scan, then automatically scans them without loading each and every class within those archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #1 from Kashyap Chamarthy kchamart@redhat.com 2011-12-13 10:10:50 EST --- 1/ rpmlint warnings (All of them seem to be benign warnings)
############### [build@dhcp201-157 SPECS]$ rpmlint scannotation.spec ../RPMS/noarch/scannotation-* ../SRPMS/scannotation-1.0.3-0.1.r12.fc17.src.rpm scannotation.spec: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz scannotation.noarch: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate scannotation.noarch: W: spelling-error %description -l en_US apis -> pis, apish, apes scannotation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados scannotation.src: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate scannotation.src: W: spelling-error %description -l en_US apis -> pis, apish, apes scannotation.src: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz 3 packages and 1 specfiles checked; 0 errors, 7 warnings. [build@dhcp201-157 SPECS]$ ###############
2/ Successful koji scratch build --
http://koji.fedoraproject.org/koji/taskinfo?taskID=3582272
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #2 from Kashyap Chamarthy kchamart@redhat.com 2011-12-14 03:34:59 EST --- (In reply to comment #0)
Sorry, correct 'SPEC' URL location is here:
http://kashyapc.fedorapeople.org/spec-files/scannotation.spec
SRPM: http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.1.r12.fc17.src.r...
Description:
Scannotation is a Java library that creates an annotation database from a set of .class files.This database is really just a set of maps that index what annotations are used and what classes are using them. Why do you need this? What if you are an annotation framework like an EJB 3.0 container and you want to automatically scan your classpath for EJB annotations so that you know what to deploy? Scannotation gives you apis that allow you to find archives in your classpath or WAR (web application) that you want to scan, then automatically scans them without loading each and every class within those archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2011-12-14 04:26:56 EST --- Review: + koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3582272
+ Source generated from svn revision 12 so no verification with upstream here
+ rpmlint on rpms gave scannotation.noarch: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate scannotation.noarch: W: spelling-error %description -l en_US apis -> pis, apish, apes scannotation.src: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate scannotation.src: W: spelling-error %description -l en_US apis -> pis, apish, apes scannotation.src: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz scannotation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 6 warnings.
+ rest looks ok in specfile
Suggestions: 1) you should preserve the timestamps of files being installed using -p. so replace cp %SOURCE1 . with cp -p %SOURCE1 .
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #4 from Kashyap Chamarthy kchamart@redhat.com 2011-12-14 06:49:17 EST --- Thanks Parag for the review. Modified spec and rebuilt SRPM.
Updated SPEC and SRPM here:
SPEC: http://kashyapc.fedorapeople.org/spec-files/scannotation.spec
SRPM: http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.2.r12.fc17.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Kashyap Chamarthy kchamart@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Kashyap Chamarthy kchamart@redhat.com 2011-12-14 07:09:55 EST --- New Package SCM Request ======================= Package Name: scannotation Short Description: A Java annotation scanner Owners: vakwetu kashyapc Branches: f16 f17 InitialCC: goldmann
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2011-12-14 08:10:38 EST --- Git done (by process-git-requests).
Did not grant access to vakwetu, not in packager group. Did not create f17 branch, f17==devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #7 from Kashyap Chamarthy kchamart@redhat.com 2011-12-14 08:20:05 EST --- Jon, can you provide access to 'goldmann' too please ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-12-19 12:27:38 EST --- scannotation-1.0.3-0.2.r12.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/scannotation-1.0.3-0.2.r12.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-12-22 17:51:11 EST --- scannotation-1.0.3-0.2.r12.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767226
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |scannotation-1.0.3-0.2.r12. | |fc16 Resolution| |ERRATA Last Closed| |2012-01-11 01:01:25
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-01-11 01:01:25 EST --- scannotation-1.0.3-0.2.r12.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org