Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: toothchart - A PHP script which graphically shows how a baby's primary teeth have erupted
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Summary: Review Request: toothchart - A PHP script which graphically shows how a baby's primary teeth have erupted Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sanjay.ankur@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://ankursinha.fedorapeople.org/toothchart/toothchart.spec SRPM URL: http://ankursinha.fedorapeople.org/toothchart/toothchart-0-0.02.0beta.fc15.s...
Description: The Baby Tooth chart is a PHP script which graphically shows how a baby's primary teeth have erupted - Eventually it'll become a POST/PHP-Nuke module. Uses only PHP and static images (i.e. no PHP graphics or FLASH, so no extra libraries needed)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |673841(fedora-medical) Alias| |toothchart
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mariobl@freenet.de AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review?
--- Comment #1 from Mario Blättermann mariobl@freenet.de 2011-06-28 14:12:29 EDT --- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3167503
$ rpmlint -i -v * toothchart.src: I: checking toothchart.src: I: checking-url http://sourceforge.net/projects/toothchart/ (timeout 10 seconds) toothchart.src: I: checking-url http://downloads.sourceforge.net/toothchart/toothchart-beta-0.02.0.tar.gz (timeout 10 seconds) toothchart.noarch: I: checking toothchart.noarch: I: checking-url http://sourceforge.net/projects/toothchart/ (timeout 10 seconds) toothchart.noarch: E: incorrect-fsf-address /usr/share/doc/toothchart/LICENSE The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
2 packages and 0 specfiles checked; 1 errors, 0 warnings.
Almost no issues, just the incorrect FSF address. You should file a bug upstream, but it's no blocker for your package.
Informal review will follow immediately.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #2 from Mario Blättermann mariobl@freenet.de 2011-06-28 15:21:11 EDT --- --------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [X] MUST: The package must be licensed with a Fedora approved license. According to the license included in the package, it should be GPLv2 (without +). The source itself doesn't say anything about the license.
[X] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 05b19b482ba86101694e63bf41d5a5e9 toothchart-beta-0.02.0.tar.gz 05b19b482ba86101694e63bf41d5a5e9 toothchart-beta-0.02.0.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available for f16. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [.] MUST: All build dependencies must be listed in BuildRequires. No BR needed anyway, the basic build environment is sufficient here.
[.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. -p switch has applied to "install".
[+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #3 from Ankur Sinha sanjay.ankur@gmail.com 2011-06-29 12:51:45 EDT --- (In reply to comment #2)
key:
[+] OK [.] OK, not applicable [X] needs work
[X] MUST: The package must be licensed with a Fedora approved license. According to the license included in the package, it should be GPLv2 (without +). The source itself doesn't say anything about the license.
[X] MUST: The License field in the package spec file must match the actual license.
Hi Mario,
I think I had referred to the site for the license:
http://sourceforge.net/projects/toothchart/
I've corrected it now to the license file included in the source.
New spec/srpm:
http://ankursinha.fedorapeople.org/toothchart/toothchart.spec
http://ankursinha.fedorapeople.org/toothchart/toothchart-0.02.0-0.1beta.fc15...
Thanks, Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Mario Blättermann mariobl@freenet.de 2011-06-29 14:15:44 EDT --- OK, looks well now. That's why:
----------------
PACKAGE APPROVED
----------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #5 from Ankur Sinha sanjay.ankur@gmail.com 2011-06-29 22:11:17 EDT --- Thank you Mario! :D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Ankur Sinha sanjay.ankur@gmail.com 2011-06-29 22:13:04 EDT --- New Package SCM Request ======================= Package Name: toothchart Short Description: A PHP script which graphically shows how a baby's primary teeth have erupted Owners: ankursinha Branches: f14 f15 InitialCC: susmit mrceresa
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-06-30 07:54:36 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-06-30 13:09:22 EDT --- toothchart-0.02.0-0.1beta.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/toothchart-0.02.0-0.1beta.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-06-30 13:09:30 EDT --- toothchart-0.02.0-0.1beta.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/toothchart-0.02.0-0.1beta.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-07-01 14:54:15 EDT --- toothchart-0.02.0-0.1beta.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |CURRENTRELEASE Last Closed| |2011-07-17 10:24:20
--- Comment #11 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-17 10:24:20 EDT --- Built and pushed to repos for testing. Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-07-18 18:26:53 EDT --- toothchart-0.02.0-0.1beta.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |toothchart-0.02.0-0.1beta.f | |c14 Resolution|CURRENTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-07-18 18:38:56 EDT --- toothchart-0.02.0-0.1beta.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716352
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|toothchart-0.02.0-0.1beta.f |toothchart-0.02.0-0.1beta.f |c14 |c15
package-review@lists.fedoraproject.org