https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Bug ID: 1272090 Summary: Review Request: nodejs-expect - Write better assertions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve-1.4.0-1.... Description: Write better assertions Fedora Account System Username: jsmith
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews), | |1269538 (IoT) Depends On| |1272088
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1272088 [Bug 1272088] Review Request: nodejs-is-regexp - Check whether a variable is a regular expression
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com
--- Comment #1 from Piotr Popieluch piotr1212@gmail.com --- Title of but is nodejs-expect but the links point to nodejs-serve, please check what the correct module should be.
In nodejs-server there is a binary. This should be symlinked to /usr/bin/<name>
eg in %install: mkdir -p %{buildroot}%{_bindir} ln -s %{nodejs_sitelib}/%{srcname}/cli.js %{buildroot}%{_bindir}/%{srcname}
and %files: %{_bindir}/%{srcname}
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- Sorry, that was a mistake on my part. I'll open a separate review for nodejs-server. In the meantime, here are the Spec and SRPM for nodejs-expect:
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.12.2...
https://bugzilla.redhat.com/show_bug.cgi?id=1272090 Bug 1272090 depends on bug 1272088, which changed state.
Bug 1272088 Summary: Review Request: nodejs-is-regexp - Check whether a variable is a regular expression https://bugzilla.redhat.com/show_bug.cgi?id=1272088
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vanmeeuwen+fedora@kolabsys. | |com QA Contact|extras-qa@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com QA Contact|vanmeeuwen+fedora@kolabsys. |extras-qa@fedoraproject.org |com |
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #3 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2...
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #4 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- We're missing the build dependency of nodejs-is-equal (I can not find an existing review request for it either).
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1363789
--- Comment #5 from Jared Smith jsmith.fedora@gmail.com --- Ask and ye shall recieve... See RHBZ#1363789
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1363789 [Bug 1363789] Review Request: nodejs-is-equal - Are these two values conceptually equal?
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1364637
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364637 [Bug 1364637] Review Request: nodejs-default-resolution - Get the default resolution time based on the current node version
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #6 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- LICENSE.md is not marked as a license file.
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #7 from Jared Smith jsmith.fedora@gmail.com --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2...
https://bugzilla.redhat.com/show_bug.cgi?id=1272090 Bug 1272090 depends on bug 1363789, which changed state.
Bug 1363789 Summary: Review Request: nodejs-is-equal - Are these two values conceptually equal? https://bugzilla.redhat.com/show_bug.cgi?id=1363789
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-expect
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-08-15 11:20:46
--- Comment #9 from Jared Smith jsmith.fedora@gmail.com --- In rawhide, closing bug
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1387531 (Node-RED)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED
https://bugzilla.redhat.com/show_bug.cgi?id=1272090
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1269538 (IoT) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora
package-review@lists.fedoraproject.org