Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Nagios-Plugin-WWW-Mechanize - Login to a web page as a user and get data as a Nagios plugin
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Summary: Review Request: perl-Nagios-Plugin-WWW-Mechanize - Login to a web page as a user and get data as a Nagios plugin Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ktdreyer@ktdreyer.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize.spec SRPM URL: http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize-0.13-1.fc1... and
Description: Login to a web page as a user and get data as a Nagios plugin. This module ties Nagios::Plugin with WWW::Mechanize so that there's less code in your perl script and the most common work is done for you.
I would like to get this package into Fedora. EPEL 5/6 would require getting perl-WWW-Mechanize into EPEL (I may be willing to be the EPEL maintainer for that in the future).
I'm a long-time Fedora user, and I'm looking to be a developer. I maintain a few RPMs at work, but this is my first couple of packages in Fedora, so I'm seeking a sponsor. My first package is at https://bugzilla.redhat.com/show_bug.cgi?id=678727
$ rpmlint SPECS/perl-Nagios-Plugin-WWW-Mechanize.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint perl-Nagios-Plugin-WWW-Mechanize-0.13-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint perl-Nagios-Plugin-WWW-Mechanize-0.13-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Koji scratch builds: F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2877483 F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2877485 F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2877486
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #1 from Ken Dreyer ktdreyer@ktdreyer.com 2011-03-01 20:20:45 EST --- Koji scratch build for F15 is actually http://koji.fedoraproject.org/koji/taskinfo?taskID=2877487
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@cern.ch AssignedTo|nobody@fedoraproject.org |steve.traylen@cern.ch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #2 from Ken Dreyer ktdreyer@ktdreyer.com 2011-03-02 14:48:39 EST --- The requisite perl-WWW-Mechanize is in EPEL 6, so I have updated my package to build there.
Updated -2 release: http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize.spec http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize-0.13-2.el6...
Koji scratch build: EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879094 F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879105 F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879107 F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2879109
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- QAContact|extras-qa@fedoraproject.org |steve.traylen@cern.ch Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #3 from Steve Traylen steve.traylen@cern.ch 2011-03-03 14:09:53 EST ---
- Package meets naming and packaging guidelines It does. - Spec file matches base package name. Yes. - Spec has consistant macro usage. Yes. - Meets Packaging Guidelines. Yes - License GPL+ or Artistic - License field in spec matches It does. - License file included in package It does - Spec in American English Yes. - Spec is legible. Yes. - Sources match upstream md5sum: $ md5sum Nagios-Plugin-WWW-Mechanize-0.13.tar.gz ../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz 8cfc2c93d84a88756666c3d7a6baf69e Nagios-Plugin-WWW-Mechanize-0.13.tar.gz 8cfc2c93d84a88756666c3d7a6baf69e ../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
- BuildRequires correct Yes - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - Doc subpackage needed/used Not needed.
- Packages %doc files don't affect runtime. The don't
- Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output.
rpmint is clean as above.
- final provides and requires are sane: COMMENT , a few double requires that could be cleaned up.
SHOULD Items:
- Should build in mock. Yes - Should build on all supported archs Yes - Should function as described. The checks work at lease. - Should have dist tag Yes. - Should package latest version Yes it's the latest
Issues:
1) I'm not entirely sure why to be honest but in the past I've been asked to change
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT to make pure_install DESTDIR=$RPM_BUILD_ROOT
2) You have in your .spec file an explicit
Requires: perl(Nagios::Plugin) Requires: perl(WWW::Mechanize)
which results in double entries in the requires from rpm -qp --requires perl-Nagios-Plugin-WWW-Mechanize-0.13-2.fc14.noarch.rpm
As a gneral rule if yours requires are being auto determined you should not include them explicitly.
3) Something I try and do is when you have a BuildRequires that is only needed on EL6 then I place it inside an OS conditional http://fedoraproject.org/wiki/DistTag#Conditionals
This makes it obvious that when RHEL6 is buried you can get rid of these lines. Of course sometimes it is requirement since the dependency names changes between releases.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #4 from Ken Dreyer ktdreyer@ktdreyer.com 2011-03-04 02:13:47 EST --- Thank you Steve. I've updated to a -3 release. http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize.spec http://adiemus.org/~kdreyer/rpms/perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6...
ChangeLog for -3: - use DESTDIR in place of PERL_INSTALL_ROOT - rm explicit Requires (Nagios::Plugin and WWW::Mechanize are auto-determined) - Wrap BuildRequires for EL6 in a conditional DistTag
Koji scratch builds: F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884086 F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884080 F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884082 EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884084
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #5 from Ken Dreyer ktdreyer@ktdreyer.com 2011-03-05 14:45:05 EST --- Removing FE-NEEDSPONSOR from this review, per https://fedorahosted.org/fesco/ticket/569
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Steve Traylen steve.traylen@cern.ch 2011-03-13 04:25:34 EDT --- Looks GOOD.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Ken Dreyer ktdreyer@ktdreyer.com 2011-03-14 00:22:26 EDT --- New Package SCM Request ======================= Package Name: perl-Nagios-Plugin-WWW-Mechanize Short Description: Login to a web page as a user and get data as a Nagios plugin Owners: ktdreyer Branches: f14 f15 el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2011-03-14 11:38:32 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-03-15 21:51:23 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-03-15 21:54:38 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-03-15 21:55:28 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Nagios-Plugin-WWW-Mechanize-0.1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-03-16 14:18:02 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-03-20 23:32:54 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Nagios-Plugin-WWW-Mech | |anize-0.13-3.fc15 Resolution| |ERRATA Last Closed| |2011-03-20 23:32:59
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-03-24 15:28:20 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Nagios-Plugin-WWW-Mech |perl-Nagios-Plugin-WWW-Mech |anize-0.13-3.fc15 |anize-0.13-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-03-31 11:17:54 EDT --- perl-Nagios-Plugin-WWW-Mechanize-0.13-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Nagios-Plugin-WWW-Mech |perl-Nagios-Plugin-WWW-Mech |anize-0.13-3.fc14 |anize-0.13-3.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #16 from Ken Dreyer ktdreyer@ktdreyer.com 2011-04-07 23:51:37 EDT --- Package Change Request ====================== Package Name: perl-Nagios-Plugin-WWW-Mechanize New Branches: EL-5 Owners: ktdreyer
The requisite WWW::Mechanize module is now in EPEL 5.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #17 from Jason Tibbitts tibbs@math.uh.edu 2011-04-08 10:02:15 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org