https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Bug ID: 1327078 Summary: Review Request: python-pyrtlsdr - Python binding for librtlsdr Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jskarvad@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr-0.2.2-1.fc... Description: Python binding for librtlsdr (a driver for Realtek RTL2832U based SDR's). Fedora Account System Username: jskarvad
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Jan Synacek jsynacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jsynacek@redhat.com Assignee|nobody@fedoraproject.org |jsynacek@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #1 from Jan Synacek jsynacek@redhat.com --- From rpmlint:
... python2-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python2 ... python3-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python3 ...
Is this intentional? Those scripts don't look like they are part of the library. If they really are, they probably shouldn't be marked as executable.
Otherwise, looks good to me.
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #2 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jan Synacek from comment #1) Thanks for the review.
From rpmlint:
... python2-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python2 ... python3-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python3 ...
Is this intentional? Those scripts don't look like they are part of the library. If they really are, they probably shouldn't be marked as executable.
Currently the rtlsdrtcp.py is installed non-executable, but it is standalone script - it is a TCP server/client for accessing a device over the network. Thus it is probably better to install it into /usr/bin and make it executable.
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #3 from Jaroslav Škarvada jskarvad@redhat.com --- New version: Spec URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr-0.2.2-2.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #4 from Jan Synacek jsynacek@redhat.com --- python2-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.pyc python2-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.pyo python3-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/rtlsdr/__pycache__/rtlsdrtcp.cpython-35.pyc python3-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/rtlsdr/__pycache__/rtlsdrtcp.cpython-35.opt-1
You probably want to remove those.
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #5 from Jaroslav Škarvada jskarvad@redhat.com --- New version: Spec URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr-0.2.2-3.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Jan Synacek jsynacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Jan Synacek jsynacek@redhat.com --- Looks ok now.
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #7 from Kevin Fenzi kevin@scrye.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pyrtlsdr
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2016-04-25 05:26:09
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc23.1 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords| |Reopened
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc23.1 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc23.1 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-04-25 05:26:09 |2016-05-04 01:23:21
https://bugzilla.redhat.com/show_bug.cgi?id=1327078
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-pyrtlsdr-0.2.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org