https://bugzilla.redhat.com/show_bug.cgi?id=2068492
Bug ID: 2068492 Summary: Review Request: fedora-appstream-metadata - Operating System AppStream Metadata for Fedora Linux Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: travier@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata.spec SRPM URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata-37-0.1.fc35.s... Description: Operating System AppStream Metadata for Fedora Linux Fedora Account System Username: siosm
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #1 from Timothée Ravier travier@redhat.com --- See https://src.fedoraproject.org/rpms/fedora-release/pull-request/217 for more context.
This enables applications (such as Discover) to figure out which releases are still supported and display information to the user if they are using and EOL release.
See: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-OS.html
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #2 from Timothée Ravier travier@redhat.com --- The "full" source is at https://github.com/travier/fedora-appstream-metadata. This includes the script used to automatically generate/update the metadata.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com CC| |ngompa13@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- Can you please include the source and generate the appstream file in the package spec?
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #5 from Timothée Ravier travier@redhat.com --- Maybe I'm missing something, but I think that I can't generate the appstream file during a build step in the specfile as this needs network access. I was planning on adding the Go "script" to the dist-git repo after the initial import as it's not really a source for the RPM itself.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Hmm, I would prefer the source to be part of the SRPM, but yeah that makes sense why you can't run the generation process during the build.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #7 from Timothée Ravier travier@redhat.com --- Can I add files and not use them? If yes then I can definitely add it to the SRPM. I would prefer not to build/install it as nobody would really us it.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- (In reply to Timothée Ravier from comment #7)
Can I add files and not use them? If yes then I can definitely add it to the SRPM. I would prefer not to build/install it as nobody would really us it.
Yes.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #9 from Timothée Ravier travier@redhat.com --- Updated SRPM & spec file: Spec URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata.spec SRPM URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata-37-0.2.fc37.s...
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- You're missing a license file.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #11 from Timothée Ravier travier@redhat.com --- Everything is MIT and explicitly marked in source code or the files themselves. Should I include the MIT LICENSE file in the SRPM?
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #12 from Timothée Ravier travier@redhat.com --- Found the relevant portion in the docs. I'll do that.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #13 from Timothée Ravier travier@redhat.com --- Updated SRPM & spec file: Spec URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata.spec SRPM URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata-37-0.3.fc37.s...
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #14 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package is named appropriately * Package builds and installs * Package licensing is correct and license file is installed * No serious issues with rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #15 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-appstream-metadata
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8bf70217cf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8bf70217cf
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-06-22 18:19:30
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8bf70217cf has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4bb9a0f4de has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4bb9a0f4de
https://bugzilla.redhat.com/show_bug.cgi?id=2068492
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4bb9a0f4de has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org