Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: lxshortcut - Small utility to edit application shortcuts
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Summary: Review Request: lxshortcut - Small utility to edit application shortcuts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@christoph-wickert.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://cwickert.fedorapeople.org/review/lxshortcut.spec SRPM URL: http://cwickert.fedorapeople.org/review/lxshortcut-0.1-1.fc11.src.rpm Description: LXShortcut is a small utility to edit application shortcuts created with freedesktop.org Desktop Entry spec. Now editing of application shortcuts becomes quite easy.
Note: This tool is meant to be started by other applications. Currently it works with lxpanel 0.4.0 (right click on a menu entry -> properties), but lxlaucher and pcmanfm will soon make use of it. To test it's functionality use something like lxshortcut -i 0 -o ~/Desktop/testlauncher.desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@iki.fi AssignedTo|nobody@fedoraproject.org |jussi.lehtola@iki.fi Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Jussi Lehtola jussi.lehtola@iki.fi 2009-05-01 02:52:52 EDT --- rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. NEEDSFIX /usr/bin/install -c -m 644 'data/lxshortcut.ui' '/builddir/build/BUILDROOT/lxshortcut-0.1-1.fc10.x86_64/usr/share/lxshortcut/lxshortcut.ui' /usr/bin/install -c -m 644 'data/choose-icon.ui' '/builddir/build/BUILDROOT/lxshortcut-0.1-1.fc10.x86_64/usr/share/lxshortcut/choose-icon.ui' - Addind INSTALL="install -p" to make install arguments should fix this.
MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. OK MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
Fix the time stamp issue before importing to cvs. The package has been
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Christoph Wickert fedora@christoph-wickert.de 2009-05-01 07:11:33 EDT --- (In reply to comment #1)
Fix the time stamp issue before importing to cvs.
Will do, thanks for the review.
New Package CVS Request ======================= Package Name: lxshortcut Short Description: Small utility to edit application shortcuts Owners: cwickert Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Dennis Gilmore dennis@ausil.us 2009-05-01 16:52:50 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
--- Comment #4 from Fedora Update System updates@fedoraproject.org 2009-05-01 17:54:07 EDT --- lxshortcut-0.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lxshortcut-0.1-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-05-01 17:54:17 EDT --- lxshortcut-0.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/lxshortcut-0.1-1.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-05-21 19:24:00 EDT --- lxshortcut-0.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-05-21 19:30:16 EDT --- lxshortcut-0.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Christoph Wickert fedora@christoph-wickert.de 2009-05-22 21:43:55 EDT --- Package Change Request ====================== Package Name: lxshortcut New Branches: EL-4 EL-5 Owners: cwickert
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-05-23 01:35:06 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498492
Christoph Wickert fedora@christoph-wickert.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |505781(LXDE)
package-review@lists.fedoraproject.org