https://bugzilla.redhat.com/show_bug.cgi?id=1294359
Bug ID: 1294359 Summary: Review Request: libsmartcols-bindings - Bindings for the util-linux libsmartcols library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings.spe... SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings-0.0... Description: Bindings for the util-linux libsmartcols library. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
--- Comment #1 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings.spe... SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/libsmartcols-bindings-0.0...
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- lkundrak's scratch build of libsmartcols-bindings-0.0.2-1.fc23.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12329771
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@v3.sk Assignee|nobody@fedoraproject.org |lrintel@redhat.com Flags| |fedora-review+
--- Comment #3 from Lubomir Rintel lkundrak@v3.sk --- * Named correctly * Correclty versioned * Using latest version * Upstream sources match * License tag okay * License good for Fedora * Builds fine in mock * SPEC file clean and legible
APPROVED
A few notes:
0.) Doesn't seem to build for me locally (f23 with updated cmake):
no theme named 'alabaster' found (missing theme.conf?)
Maybe you may want to depend on python-sphinx-alabaster or whatever provides the theme, since you're explicitly using it? It could be that it's dragged into the koji buildroot by dumb luck.
1.) The perl subpackage should probably provide perl(smartcols) = NVR (since it's not generated automatically as the package doesn't use a pure perl bootstrap wrapper).
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
--- Comment #4 from Igor Gnatenko i.gnatenko.brain@gmail.com ---
Maybe you may want to depend on python-sphinx-alabaster or whatever provides the theme, since you're explicitly using it? It could be that it's dragged into the koji buildroot by dumb luck.
Because I'm running rawhide it is already default theme for sphinx (in upstream alos), so it is explicitly required by sphinx... But for f23 looks like it is not true.
1.) The perl subpackage should probably provide perl(smartcols) = NVR (since it's not generated automatically as the package doesn't use a pure perl bootstrap wrapper).
Will do!
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|lrintel@redhat.com |lkundrak@v3.sk
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/libsmartcols-bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1294359
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2016-07-07 05:14:13
package-review@lists.fedoraproject.org