Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Text-Trac - Perl extension for formatting text with Trac Wiki Style
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Summary: Review Request: perl-Text-Trac - Perl extension for formatting text with Trac Wiki Style Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: timosha@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://timon.perm.ru/download/perl-Text-Trac.spec SRPM URL: http://timon.perm.ru/download/perl-Text-Trac-0.13-1.fc9.src.rpm Description: Text::Trac parses text with Trac WikiFormatting and convert it to html format.
more info: http://search.cpan.org/dist/Text-Trac/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #1 from Timon timosha@gmail.com 2008-09-26 09:30:01 EDT --- *** Bug 464140 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br Alias| |perl-Text-Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |464117
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mmaslano@redhat.com Flag| |fedora-review+
--- Comment #2 from Marcela Maslanova mmaslano@redhat.com 2008-11-19 08:20:19 EDT --- OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field (same as Perl) matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package isn't need. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #3 from Timon timosha@gmail.com 2009-06-19 09:59:27 EDT --- Created an attachment (id=348669) --> (https://bugzilla.redhat.com/attachment.cgi?id=348669) perl-Text-Trac-0.15-1.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #4 from Timon timosha@gmail.com 2009-06-19 10:00:04 EDT --- Created an attachment (id=348670) --> (https://bugzilla.redhat.com/attachment.cgi?id=348670) perl-Text-Trac.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #5 from Timon timosha@gmail.com 2009-06-19 10:00:36 EDT --- new version perl-Text-Trac-0.15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #6 from Marcela Maslanova mmaslano@redhat.com 2009-06-19 10:18:57 EDT --- Correct me if I'm wrong. But you wasn't still sponsored, so you don't have commit access into cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #7 from Timon timosha@gmail.com 2009-06-19 10:49:42 EDT --- yup. I need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Matej Cepl mcepl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment mime|application/octet-stream |text/plain type| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jan Klepek jan.klepek@hp.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.klepek@hp.com
--- Comment #8 from Jan Klepek jan.klepek@hp.com 2009-08-15 09:10:50 EDT --- Hi Timon,
1] please bump everytime you provide new version of package release number and post links to new version in your reply
2] %defattr(0644,root,root,0755) do you have any reason why not to use %defatter(-,root,root,-) ? https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
3] cp in makefile is without -p switch, write patch that cp in Makefile will be performed with -p switch (sed during prep will be good enough) https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
4] BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod)
you have to include this as without it, not all tests are performed and you break this guideline: https://fedoraproject.org/wiki/Packaging:Perl#Perl_Packaging
Hi Marcela,
official review for new packagers which are not yet sponsored must be done by sponsor.
http://fedoraproject.org/wiki/Package_Review_Process#Reviewer I think that you should keep this ticket unassigned until Timon is sponsored. That sponsors will see that this ticket needs attention and is not assigned.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jan Klepek jan.klepek@hp.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |
--- Comment #9 from Jan Klepek jan.klepek@hp.com 2009-08-15 09:16:46 EDT --- Marcela,
please clear fedora.review as there are things which needs to be adressed before this package meets packaging guidelines and as Timon is not yet sponsored so fedora.review+ could be set only by sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(timosha@gmail.com | |)
--- Comment #10 from Jason Tibbitts tibbs@math.uh.edu 2009-11-02 21:32:03 EDT --- It's been quite some time since comment #8 with no response from the submitter of this ticket. I guess it should be closed soon if nothing further happens.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Timon timosha@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(timosha@gmail.com | |) |
--- Comment #11 from Timon timosha@gmail.com 2009-11-03 03:20:36 EDT --- (In reply to comment #8)
1] please bump everytime you provide new version of package release number and post links to new version in your reply
I have some problems with public web server. So I attach spec and SRPM.
2] %defattr(0644,root,root,0755) do you have any reason why not to use %defatter(-,root,root,-) ? https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
fixed
3] cp in makefile is without -p switch, write patch that cp in Makefile will be performed with -p switch (sed during prep will be good enough) https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
This is CPAN Package and Makefile generates using Makefile.PL perl script. I can sed in %build section, but I don't think this is good idea. I looked into other SRPM made from CPAN, but didn't find any resolutions of this problem.
4] BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod)
fixed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Timon timosha@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #348670|0 |1 is obsolete| |
--- Comment #12 from Timon timosha@gmail.com 2009-11-03 03:22:23 EDT --- Created an attachment (id=367264) --> (https://bugzilla.redhat.com/attachment.cgi?id=367264) perl-Text-Trac.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Timon timosha@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #348669|0 |1 is obsolete| |
--- Comment #13 from Timon timosha@gmail.com 2009-11-03 03:45:38 EDT --- Created an attachment (id=367267) --> (https://bugzilla.redhat.com/attachment.cgi?id=367267) perl-Text-Trac-0.15-1.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #14 from Timon timosha@gmail.com 2009-11-03 03:48:11 EDT --- (In reply to comment #8)
please bump everytime you provide new version of package release number and post links to new version in your reply
perl-Text-Trac-0.15-1
https://bugzilla.redhat.com/attachment.cgi?id=367267 - perl-Text-Trac-0.15-1.fc12.src.rpm https://bugzilla.redhat.com/attachment.cgi?id=367264 - perl-Text-Trac.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #15 from Jan Klepek jan.klepek@gmail.com 2010-06-10 01:48:18 EDT --- Hi Timon, it is better to have this somewhere on web and put just links to that specfile/src.rpm (In reply to comment #11)
3] cp in makefile is without -p switch, write patch that cp in Makefile will be performed with -p switch (sed during prep will be good enough) https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
This is CPAN Package and Makefile generates using Makefile.PL perl script. I can sed in %build section, but I don't think this is good idea. I looked into other SRPM made from CPAN, but didn't find any resolutions of this problem.
Why do you think it is wrong idea? if Makefile is not ok by fedora guidelines, you need to alter it into way that it will be ok with guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|mmaslano@redhat.com |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
--- Comment #16 from Jason Tibbitts tibbs@math.uh.edu 2010-11-22 21:17:59 EST --- Is anything happening with this ticket? I suspect that few people want to review it because you make it difficult to get the files. Bugzilla attachments are not a very good way to do this, which is why we offer hosting for this kind of thing. Our documentation tells you how to request hosting, which suggests to me that you've not read it. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |StalledSubmitter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464141
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution| |NOTABUG Status Whiteboard|StalledSubmitter | Last Closed| |2011-01-10 18:37:02
--- Comment #17 from Jason Tibbitts tibbs@math.uh.edu 2011-01-10 18:37:02 EST --- No response in ages; closing.
package-review@lists.fedoraproject.org