https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Bug ID: 1307200 Summary: Review Request: kjots - KDE Notes application Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: me@dvratil.cz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://dvratil.fedorapeople.org/spec/kjots.spec SRPM URL: https://dvratil.fedorapeople.org/spec/kjots-5.0.1-1.fc23.src.rpm Description: KJots is an application for writing and organizing notes. KJots used to be part of the kdepim package, but as of 15.08 it was removed from KDE PIM. KJots is now being released as a standalone application outside of KDE Applications. Fedora Account System Username: dvratil
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Daniel Vrátil me@dvratil.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |656997 (kde-reviews) Alias| |kjots
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Daniel Vrátil me@dvratil.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews) Depends On|656997 (kde-reviews) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- Offhand, for upgrade path, probably need to introduce at least: Epoch: 7 since that's what previous kdepim package used
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- Nevermind, I see we foresaw that and included Epoch: 0 in the subpkgs before.
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #3 from Rex Dieter rdieter@math.unl.edu --- naming: ok
sources: ok edb0a82781dbb75d1fe69f2eb6f7cf28 kjots-5.0.1.tar.xz
license: ok
scriptlets: NOT ok
1. icon scriptlets reference (undefined?) macro: %{_iconsdir}, probably want instead: %{_datadir}/icons (or define %_iconsdir)
2. MUST add appdata validation scriptlet https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage
3. SHOULD use better URL, something like URL: http://projects.kde.org/kjots
4. MUST include licenses in %files, add: %license COPYING and optinally %license COPYING.LIB too
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@dvratil.cz Flags| |needinfo?(me@dvratil.cz)
--- Comment #4 from Rex Dieter rdieter@math.unl.edu --- ping, can you give an update?
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Daniel Vrátil me@dvratil.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(me@dvratil.cz) |
--- Comment #5 from Daniel Vrátil me@dvratil.cz --- Spec URL: https://dvratil.fedorapeople.org/spec/kjots.spec SRPM URL: https://dvratil.fedorapeople.org/spec/kjots-5.0.1-2.fc23.src.rpm
* Mon Mar 14 2016 Daniel Vrátil dvratil@fedoraproject.org - 5.0.1-2 - fix url - fix scriptlets - fix %%license and %%doc - validate appdata
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- looks good, approved
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kjots
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-03-29 09:58:45
--- Comment #8 from Rex Dieter rdieter@math.unl.edu --- I see kjots imported and built, closing
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |MODIFIED Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #9 from Raphael Groner projects.rg@smart.ms --- https://bodhi.fedoraproject.org/updates/kjots → 404
Can you provide an (at least test) build for Fedora 23?
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Daniel Vrátil me@dvratil.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed|2016-03-29 09:58:45 |2016-03-30 19:39:00
--- Comment #10 from Daniel Vrátil me@dvratil.cz --- Raphael, this kjots package is only available in F24 and rawhide. On F23 we ship KDEPIM4, where KJots is available as part of the kdepim package.
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #11 from Raphael Groner projects.rg@smart.ms --- You talk about bug #1314974, right?
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1314974
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #12 from Daniel Vrátil me@dvratil.cz --- No. In Fedora <= 23 we ship kdepim 4.14.x in package "kdepim" based on Qt4 and KDE4 (called usually "KDEPIM4"), which includes KJots and all the other KDE PIM applications. In F24 we updated to kdepim 15.12 as part of KDE Applications 15.12 release which is based on Qt5 and KF5 (called "KDEPIM5") and is not compatible with the KDE4 versions. KJots has been ported to Qt5 too, but is being released separately by upstream, not as part of KDE Applications. Therefore it's not part of the "kdepim4" compatibility package from bug #1314974, but a standalone package.
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- kjots-5.0.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |---
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1307200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-03-30 19:39:00 |2016-05-10 07:47:10
package-review@lists.fedoraproject.org