https://bugzilla.redhat.com/show_bug.cgi?id=1532094
Bug ID: 1532094 Summary: Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-s... SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-s... Description: Hypothesis strategy that generates arbitrary d-bus signatures Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1532084
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1532084 [Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser for a dbus signature
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com ---
%global sum Hypothesis strategy that generates arbitrary d-bus signatures
No need, put summary into Summary and use %{summary} later on.
Source0: https://github.com/stratis-storage/%%7Bsrcname%7D/archive/v%%7Bversion%7D.ta...
filename should be meaningful, also use shortcut... Source0: %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz
BuildRequires: python3-devel Requires: python3-hypothesis
Move those under respective package. Also missing BuildRequires: python3-setuptools and I guess BuildRequires: python3-hypothesis
%{python3_sitelib}/*
Be more specific, do not use wildcard blindly.
A Hypothesis Strategy for Generating Arbitrary DBus Signatures
Description should end with fullstop.
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #2 from Igor Gnatenko ignatenko@redhat.com --- And tests are not running, you should add BuildRequires: python3-pytest and run tests using py.test-%{python3_version} -v tests
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #3 from Igor Gnatenko ignatenko@redhat.com --- Also, neither %doc or %license is specified. All files are in place, so you should reference them.
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #4 from Ilya Gradina ilya.gradina@gmail.com --- (In reply to Igor Gnatenko from comment #3)
Also, neither %doc or %license is specified. All files are in place, so you should reference them.
thx).
new spec: https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-s... new srpm: https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-s...
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |ignatenko@redhat.com Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #5 from Igor Gnatenko ignatenko@redhat.com --- Everything looks good now.
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hs-dbus-signature
https://bugzilla.redhat.com/show_bug.cgi?id=1532094
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-01-08 08:48:17
package-review@lists.fedoraproject.org