https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Bug ID: 1240634 Summary: Review Request: python-afl - Module that enables Afl fork server for Python code Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: mcyprian@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mstuchli.fedorapeople.org/python-afl.spec SRPM URL: https://mstuchli.fedorapeople.org/python-afl-0.2-1.fc22.src.rpm Koji build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=10309630
Description: Python-afl is an experimental module that enables American fuzzy lop fork server and instrumentation for pure-Python code. Fedora Account System Username: mcyprian
This is my first package and I am looking for a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Michal Cyprian mcyprian@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rkuska@redhat.com Assignee|nobody@fedoraproject.org |rkuska@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
--- Comment #1 from Robert Kuska rkuska@redhat.com --- 1. It is not needed to define __python2 and python2_sitearch macros at the top of your specfile, they are already defined and ready to use 2. You miss a LICENSE file, this file is missing also in upstream, you should add LICENSE file as a new Source also consider reporting this to upstream, from packaging guidelines[0]: "If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license. If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake." 3. You don't list %doc files - README.rst changelog and trophy-case.rst 4. There is a macro in comment "# %check section was not included, because properly working test" you should escape your macro or remove it from comment 5. Your summaries are too long, make them shorter :-) 6. Description line at python3 subpackage is also too long 7. Use %{_bindir} macro at %files section 8. Changelog is in a wrong format, correct format is: * Tue Jul 07 2015 Michal Cyprian mcyprian@redhat.com - 0.2-1 9. .so files shipped by your rpms seems to have wrong file permissions 775, you can use rpm files directive to solve this - %defattr(755, root, root, -)[1]
[0]https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li... [1]http://www.rpm.org/max-rpm-snapshot/s1-rpm-specref-files-list-directives.htm...
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
--- Comment #2 from Michal Cyprian mcyprian@redhat.com --- Thank you for feed back. I've fixed all mentioned problems. I hope Spec file is now correct. Here are updated versions of files:
Spec URL: https://mstuchli.fedorapeople.org/python-afl.spec SRPM URL: https://mstuchli.fedorapeople.org/python-afl-0.2-1.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert Kuska rkuska@redhat.com --- Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Michal Cyprian mcyprian@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
--- Comment #4 from Michal Cyprian mcyprian@redhat.com --- New Package SCM Request ======================= Package Name: python-afl Short Description: Module that enables Afl fork server for Python code Upstream URL: https://pypi.python.org/pypi/python-afl/ Owners: mcyprian Branches: f22 f23 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-afl-0.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-afl-0.2-1.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-afl-0.2-1.fc22 has been pushed to the Fedora 22 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Michal Cyprian mcyprian@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NOTABUG Last Closed| |2015-09-03 05:03:28
https://bugzilla.redhat.com/show_bug.cgi?id=1240634
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
package-review@lists.fedoraproject.org