https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Bug ID: 1365794 Summary: Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ignatenko@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt-1.1.1... Description: Alternate keyring backend implementations for use with the python-keyring package. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-keyrings-alt
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1365765
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1365765 [Bug 1365765] python-wheel 0.29.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Charalampos Stratakis cstratak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cstratak@redhat.com Assignee|nobody@fedoraproject.org |cstratak@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Charalampos Stratakis cstratak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
--- Comment #1 from Charalampos Stratakis cstratak@redhat.com --- Missing some BuildRequires from both subpackages in order to run the tests:
BuildRequires: python2-setuptools_scm BuildRequires: python-keyring BuildRequires: python2-mock
BuildRequires: python3-setuptools_scm BuildRequires: python3-keyring BuildRequires: python3-mock
README.txt file doesn't exist, it should be README.rst
Correct path for nspkg.pth files should be in the form:
%{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}-nspkg.pth
and
%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}-nspkg.pth
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
--- Comment #2 from Charalampos Stratakis cstratak@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: https://github.com/jaraco/keyrings.alt/issues/6
Sent a pull request upstream as well to include a license: https://github.com/jaraco/keyrings.alt/pull/8
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
--- Comment #3 from Charalampos Stratakis cstratak@redhat.com --- Pull request has been merged and version 1.2 was released which includes the MIT license file, so the review can proceed.
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Petr Viktorin pviktori@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pviktori@redhat.com Flags| |needinfo?(ignatenko@redhat. | |com)
--- Comment #4 from Petr Viktorin pviktori@redhat.com --- What's the status here?
https://bugzilla.redhat.com/show_bug.cgi?id=1365794
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(ignatenko@redhat. | |com) | Last Closed| |2018-02-23 06:52:08
--- Comment #5 from Igor Gnatenko ignatenko@redhat.com --- Sorry, don't have time for this.
package-review@lists.fedoraproject.org