Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-passlib - Comprehensive password hashing framework supporting over 20 schemes
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Summary: Review Request: python-passlib - Comprehensive password hashing framework supporting over 20 schemes Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: matt_domsch@dell.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://domsch.com/fedora/python-passlib/python-passlib.spec SRPM URL: http://domsch.com/fedora/python-passlib/python-passlib-1.5.3-1.src.rpm Description: Passlib is a password hashing library for Python 2 & 3, which provides cross-platform implementations of over 20 password hashing algorithms, as well as a framework for managing existing password hashes. It's designed to be useful for a wide range of tasks, from verifying a hash found in /etc/shadow, to providing full-strength password hashing for multi-user application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #1 from Matt Domsch matt_domsch@dell.com 2011-10-18 10:14:17 EDT --- domsch.com is horked, so I put them at http://mdomsch.fedorapeople.org/python-passlib/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #2 from Robert Knight knight@princeton.edu 2011-10-18 10:57:24 EDT --- The spec file is missing a BuildRequires of python-setuptools. With that change it does build.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #3 from Robert Knight knight@princeton.edu 2011-10-18 11:06:48 EDT --- Spec URL: http://www.princeton.edu/~knight/fedora/python-passlib.spec SRPM URL: http://www.princeton.edu/~knight/fedora/python-passlib-1.5.3-1.src.rpm rpmlint output: http://www.princeton.edu/~knight/fedora/rpmlint.txt
Only change was the addition of the BuildRequires and rerunning rpmlint.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Mark McLoughlin markmc@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |markmc@redhat.com Flag| |fedora-review+
--- Comment #4 from Mark McLoughlin markmc@redhat.com 2011-10-18 12:00:52 EDT --- Robert's version looks good to me. rpmlint passes, packaging looks sane. Licensing is correct. Installs fine and sample code from docs on website works.
I'd like to see these 3 minor things fixed up before or after importing:
1. Let's do what the comment says:
# Remove CFLAGS=... for noarch packages (unneeded)
2. Don't need 'rm -rf %{buildroot}' in %install:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
3. Don't need to define %{python_sitelib} anymore:
http://fedoraproject.org/wiki/Packaging:Python#Macros
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #5 from Robert Knight knight@princeton.edu 2011-10-18 13:36:37 EDT --- Corrected at the URL's in Comment 3.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Matt Domsch matt_domsch@dell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Matt Domsch matt_domsch@dell.com 2011-10-18 14:58:35 EDT --- New Package SCM Request ======================= Package Name: python-passlib Short Description: Comprehensive password hashing framework Owners: mdomsch Branches: f16 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-10-19 08:30:10 EDT --- Git done (by process-git-requests).
Mark, please take ownership of review BZs. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-10-19 11:25:04 EDT --- python-passlib-1.5.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-passlib-1.5.3-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-10-19 22:24:42 EDT --- python-passlib-1.5.3-1.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746976
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-passlib-1.5.3-1.fc16 Resolution| |ERRATA Last Closed| |2012-01-07 18:07:28
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-01-07 18:07:28 EST --- python-passlib-1.5.3-1.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org