https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Bug ID: 1623300 Summary: Review Request: R-tweenr - Interpolate Data for Smooth Animations Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org//R-tweenr.spec SRPM URL: https://qulogic.fedorapeople.org//R-tweenr-0.1.5-1.fc28.src.rpm
Description: In order to create smooth animation between states of data, tweening is necessary. This package provides a range of functions for creating tweened data that plugs right into functions such as gg_animate() from the 'gganimate' package. Furthermore it adds a number of vectorized interpolaters for common R data types such as numeric, date and colour.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29357688
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |i.ucar86@gmail.com Assignee|nobody@fedoraproject.org |i.ucar86@gmail.com
--- Comment #2 from Iñaki Ucar i.ucar86@gmail.com --- Just one minor issue/question before approving: what happens with headers under src/? The R packaging guidelines do not specify what to do with them. In principle, they should be placed in a -devel subpackage, but anyway they are useless for other R packages if they are not under inst/include/.
- No rpmlint errors, some spelling warnings (false positives). - Requires, BuildRequires ok. - Compatible licenses, breakdown specified. - Files/dirs ok.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- They aren't installed, so no need for the -devel subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #4 from Iñaki Ucar i.ucar86@gmail.com --- They are installed in the -debugsource subpackage, and the fedora-review tool complains about this. This is why I'm asking.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Those are just for debugging; they don't need to be split up. rpmlint is probably complaining about the executable bit that I forgot to remove. Here's an update with that corrected:
Spec URL: https://qulogic.fedorapeople.org/R-tweenr.spec SRPM URL: https://qulogic.fedorapeople.org/R-tweenr-0.1.5-2.fc28.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #6 from Iñaki Ucar i.ucar86@gmail.com --- Ok! Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9354d688bf
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #7 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-tweenr
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-089d519f63
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9061c50408
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9354d688bf
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-089d519f63
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9061c50408
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-09-07 11:24:37
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1623300
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- R-tweenr-0.1.5-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org