https://bugzilla.redhat.com/show_bug.cgi?id=1065627
Bug ID: 1065627 Summary: Review Request: pire - Perl Incompatible Regular Expressions library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cickumqt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://cicku.me/pire.spec SRPM URL: http://cicku.me/pire-0.0.5-1.fc21.src.rpm Description: Pire is developed in Yandex (http://company.yandex.ru/) as a part of its web crawler. It aims at checking a huge amount of text against relatively many regular expressions. Roughly speaking, it can just check whether given text maches the certain regexp, but can do it really fast (more than 400 MB/s on our hardware is common). Even more, multiple regexps can be combined together, giving capability to check the text against apx.10 regexps in a single pass (and mantaining the same speed).
Since Pire examines each character only once, without any lookaheads or rollbacks, spending about five machine instructions per each character, it can be used even in realtime tasks.
On the other hand, Pire has very limited functionality (compared to other regexp libraries). Pire does not have any Perlish conditional regexps, lookaheads & backtrackings, greedy/nongreedy matches; neither has it any capturing facilities. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=1065627
Kamil Dudka kdudka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kdudka@redhat.com Assignee|nobody@fedoraproject.org |kdudka@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1065627
Kamil Dudka kdudka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?
--- Comment #1 from Kamil Dudka kdudka@redhat.com --- - %description contains trailing white spaces and few typos: maches -> matches mantaining -> maintaining apx.10 -> apx. 10 realtime -> real-time nongreedy -> non-greedy
- I would move running autoreconf to %prep assuming it really needs to be run (a comment justifying it would help)
- obsolete macro AC_PROG_LIBTOOL found in: pire-release-0.0.5/configure.ac:15
- running autoreconf with recent autotools produces a lot of warnings:
pire/Makefile.am:11: warning: source file 'scanners/null.cpp' is in a subdirectory, pire/Makefile.am:11: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. pire/Makefile.am:11: warning: source file 'stub/utf8.cpp' is in a subdirectory, pire/Makefile.am:11: but option 'subdir-objects' is disabled pire/Makefile.am:56: warning: source file 'extra/capture.cpp' is in a subdirectory, pire/Makefile.am:56: but option 'subdir-objects' is disabled pire/Makefile.am:56: warning: source file 'extra/count.cpp' is in a subdirectory, pire/Makefile.am:56: but option 'subdir-objects' is disabled pire/Makefile.am:56: warning: source file 'extra/glyphs.cpp' is in a subdirectory, pire/Makefile.am:56: but option 'subdir-objects' is disabled /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libpire.la': linking libtool libraries using a non-POSIX /usr/share/automake-1.14/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac' pire/Makefile.am:10: while processing Libtool library 'libpire.la' pire/Makefile.am: installing './depcomp' configure.ac: installing './ylwrap' tests/Makefile.am:10: warning: source file 'stub/cppunit.cpp' is in a subdirectory, tests/Makefile.am:10: but option 'subdir-objects' is disabled /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libpire_unit.la': linking libtool libraries using a non-POSIX /usr/share/automake-1.14/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac' tests/Makefile.am:9: while processing Libtool library 'libpire_unit.la' parallel-tests: installing './test-driver' autoreconf: Leaving directory `.'
https://bugzilla.redhat.com/show_bug.cgi?id=1065627
Kamil Dudka kdudka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@cicku.me Flags|needinfo? |needinfo?(i@cicku.me)
--- Comment #2 from Kamil Dudka kdudka@redhat.com --- There seems to be no progress in the past 18 months. Christopher, is this review request still valid?
https://bugzilla.redhat.com/show_bug.cgi?id=1065627
Kamil Dudka kdudka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |WONTFIX Last Closed| |2016-07-08 09:09:09
--- Comment #3 from Kamil Dudka kdudka@redhat.com --- Staled since February 2014. URLs in comment #0 do not seem to work any more. Closing...
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org