Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956255
Bug ID: 956255 Summary: Review Request: glite-info-update-endpoints - Script to collect LDAP endpoins to populate the BDII Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: maria.alandes.pradillo@cern.ch QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Category: ---
Spec URL: https://malandes.web.cern.ch/malandes/spec/glite-info-update-endpoints.spec SRPM URL: https://malandes.web.cern.ch/malandes/slc6/glite-info-update-endpoints-2.0.1...
Description:
Hi,
I would like to release the glite-info-update-endpoints package for the first time in EPEL. This is one of my first packages and I need a sponsor.
glite-info-update-endpoints is a script that by default collects LDAP endpoints from the EGI and OSG projects, although it can be customized to provide a different LDAP endpoint list . The core package, bdii, is already part of EPEL and I would like to release now all the remaining ones that comprise all together a site or top BDII.
I have tested the build works fine in koji, please check: http://koji.fedoraproject.org/koji/taskinfo?taskID=5296628
Fedora Account System Username: malandes
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956255
--- Comment #1 from maria.alandes.pradillo@cern.ch --- Fixed spec file (missing source URL information):
Spec URL: https://malandes.web.cern.ch/malandes/spec/glite-info-update-endpoints.spec SRPM URL: https://malandes.web.cern.ch/malandes/epel/glite-info-update-endpoints-2.0.1...
New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5297936
https://bugzilla.redhat.com/show_bug.cgi?id=956255
maria.alandes.pradillo@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=956255
Veaceslav Mindru mindruv@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mindruv@gmail.com
--- Comment #2 from Veaceslav Mindru mindruv@gmail.com --- Hello Maria.
Is this targeted for EPEL5 releases or EPEL6 releases ? In case EPEL6 please mind this.
Drop this line.
BuildRoot: %{_tmppath}/%{name}-%{version}-build
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overvie... BuildRoot: This is where files will be "installed" during the %install process (after the %build process). This is now redundant in Fedora and is only needed for EPEL5. By default, the build root is placed in "%{_topdir}/BUILDROOT/".
drop rm -rf in %install section
%install rm -rf %{buildroot}
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_sectio...
drop %clean section
%clean rm -rf %{buildroot}
https://bugzilla.redhat.com/show_bug.cgi?id=956255
--- Comment #3 from Veaceslav Mindru mindruv@gmail.com --- Hello,
please review also E/W from rpmlint.
glite-info-static.spec:5: W: non-standard-group System/Monitoring glite-info-static.spec:9: W: macro-in-comment %{name} glite-info-static.spec:9: W: macro-in-comment %{version} glite-info-static.spec:10: W: macro-in-comment %{name} glite-info-static.spec:10: W: macro-in-comment %{version} glite-info-static.spec:10: W: macro-in-comment %{name} glite-info-static.spec:10: W: macro-in-comment %{version}
VM
https://bugzilla.redhat.com/show_bug.cgi?id=956255
--- Comment #4 from maria.alandes.pradillo@cern.ch --- This is targeted for both EPEL 5 and EPEL 6.
The rpmlint output you have posted here is from a different package: glite-info-static.
https://bugzilla.redhat.com/show_bug.cgi?id=956255
--- Comment #5 from maria.alandes.pradillo@cern.ch --- There is a newer version of this package: https://linuxsoft.cern.ch/koji/koji-x86_64/RPMS.bdii6-source/glite-info-upda...
package-review@lists.fedoraproject.org