Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Merge Review: perl-MIME-Lite - low-calorie MIME generator
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Summary: Merge Review: perl-MIME-Lite - low-calorie MIME generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmaslano@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
SRPM: http://kojipkgs.fedoraproject.org/packages/perl-MIME-Lite/3.027/2.fc13/src/p... SPEC: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1712343&filename=perl-... Description: MIME::Lite is intended as a simple, standalone module for generating (not parsing!) MIME messages... specifically, it allows you to output a simple, decent single- or multi-part message with text or binaryattachments. It does not require that you have the Mail:: or MIME:: modules installed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jskarvad@redhat.com AssignedTo|nobody@fedoraproject.org |jskarvad@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
--- Comment #1 from Jaroslav Škarvada jskarvad@redhat.com 2010-01-27 04:10:20 EST --- MUST items: [NO] rpmplint is silent perl-MIME-Lite.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
[YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [NO] License file is present, matching with spec file. Comment 1)
[YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. Comment 2)
[YES] Sources match upstream. [YES] Package builds OK. [YES] BuildRequires is correct. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [NO] Package has no duplicity in %files. Comment 3)
[YES] Permission on files are set properly. [YES] %clean section is correct. [YES] Spec file has consistant macro usage. [YES] Package is code or permissable content. [YES] %doc files don't affect runtime. [YES] No .la libtool archives. [YES][Perl] Package doesn't own files/directories that other packages own. [YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install. [YES] Spec file is valid UTF-8.
Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets. [YES] Package contains man pages.
**Comments: 1) COPYING and LICENSE files are not packaged into RPM.
2) In %description second sentence should start with capital letter. There is extra space after second sentence.
3) changes.pod is installed two times: -rw-r--r-- /usr/share/doc/perl-MIME-Lite-3.027/changes.pod -r--r--r-- /usr/share/perl5/MIME/changes.pod
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
--- Comment #2 from Marcela Mašláňová mmaslano@redhat.com 2010-01-27 05:24:15 EST --- 1/ added 2/ fixed 3/ fixed
But rpmlint got fixed! More errors was produced: [marca@caladan devel]$ rpmlint noarch/perl-MIME-Lite-3.027-3.fc13.noarch.rpm perl-MIME-Lite.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti - multi is okay. perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_fwd perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_postcard perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_longlines perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/nodisp perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_hack perl-MIME-Lite.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-MIME-Lite-3.027/README perl-MIME-Lite.noarch: W: spurious-executable-perm /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_gif perl-MIME-Lite.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-MIME-Lite-3.027/COPYING perl-MIME-Lite.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-MIME-Lite-3.027/contrib/MailTool.pm perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/contrib/MailTool.pm perl(Net::Config) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_fwd /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_postcard /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_longlines /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/nodisp /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_hack /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_gif /usr/bin/perl perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/contrib/MailTool.pm perl(Mail::Address) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_fwd perl(Getopt::Std) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_longlines perl(Getopt::Std) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_hack perl(Getopt::Std) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/examples/mime_gif perl(Getopt::Std) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/contrib/MailTool.pm perl(Sys::Hostname) perl-MIME-Lite.noarch: W: doc-file-dependency /usr/share/doc/perl-MIME-Lite-3.027/contrib/MailTool.pm perl(Net::SMTP) The rest of warning is problem with examples in docs. They need interpreter, but they are not executable, so it shouldn't be a problem for review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Jaroslav Škarvada jskarvad@redhat.com 2010-01-27 09:35:59 EST --- perl-MIME-Lite-3.027-3, fedora‑review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556404
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org