Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: tkabber-plugins - Additional plugins for tkabber
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Summary: Review Request: tkabber-plugins - Additional plugins for tkabber Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: krege@land.ru QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins.spec SRPM URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins-0.11.1-1.svn1948.fc14.... Description: There are an additional plugins for tkabber (https://bugzilla.redhat.com/show_bug.cgi?id=650180), extending its functionality.
# rpmlint tkabber-plugins-0.11.1-1.svn1948.fc14.noarch.rpm tkabber-plugins-0.11.1-1.svn1948.fc14.src.rpm tkabber-plugins.src: W: strange-permission tkabber-plugins-snapshot.sh 0755L tkabber-plugins.src:13: W: macro-in-comment %{name} tkabber-plugins.src:13: W: macro-in-comment %{version} tkabber-plugins.src: W: invalid-url Source0: tkabber-plugins-0.11.1.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
strange-permission: Script to get current version og tkabber plugins, so it needs to be +x. macro-in-comment: Source0 reservertion for release, %{name} and %{version} do have no hurt. So, it is a explonation for "invalid-url Source0" too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Dmitrij S. Kryzhevich krege@land.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |650180
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2010-11-07 02:33:39 EST --- taking this for review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Bug 650181 depends on bug 650180, which changed state.
Bug 650180 Summary: Review Request: tkabber - Client for the Jabber instant messaging system https://bugzilla.redhat.com/show_bug.cgi?id=650180
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Status|MODIFIED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #2 from Dmitrij S. Kryzhevich krege@land.ru 2010-12-03 09:54:32 EST --- Peter, ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #3 from Dmitrij S. Kryzhevich krege@land.ru 2010-12-13 07:15:31 EST --- Spec URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins.spec SRPM URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins-0.11.1-2.svn1948.fc14....
Updated License tag.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2010-12-14 09:08:09 EST --- Ok, the situation with licensing is much better now. Ok, here is my
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/tkabber-plugins-0.11.1-2.svn1948.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license.
+/- All files, containing the text of the license(s) for the package, must be included in %doc. So. please, add also *all* license.terms files. I suggest to rename them in according to particular plugins they corresponds to.
+ The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/BUILD: diff -ru tkabber-plugins-0.11.1 tkabber-plugins-0.11.1.from_package/ sulaco ~/rpmbuild/BUILD:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8.
Ok, so, please, add the license files and I'll continue.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #5 from Dmitrij S. Kryzhevich krege@land.ru 2010-12-15 04:26:17 EST --- As many plugins have same licenses, I think there no need to make copy for each. Also, there are no GPL license files for those plugins that have it.
Spec URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins.spec SRPM URL: http://krege.fedorapeople.org/tkabber/tkabber-plugins-0.11.1-3.svn1948.fc14....
changelog * Wed Dec 15 2010 Dmitrij S. Kryzhevich krege@land.ru - 0.11.1-3.svn1948 - Add license files to %%doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2010-12-15 05:45:05 EST --- Ok, now it looks good enough for me. This package is
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Dmitrij S. Kryzhevich krege@land.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Dmitrij S. Kryzhevich krege@land.ru 2010-12-15 05:54:13 EST --- Thanks.
New Package SCM Request ======================= Package Name: tkabber-plugins Short Description: Additional plugins for tkabber Owners: krege Branches: f13 f14 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2010-12-15 08:54:08 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-12-24 07:33:54 EST --- tkabber-plugins-0.11.1-3.svn1948.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-12-24 07:33:59 EST --- tkabber-plugins-0.11.1-3.svn1948.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-12-24 19:22:14 EST --- tkabber-plugins-0.11.1-3.svn1948.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tkabber-plugins'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/tkabber-plugins-0.11.1-3.svn1948.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-01-10 16:27:31 EST --- tkabber-plugins-0.11.1-3.svn1948.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |tkabber-plugins-0.11.1-3.sv | |n1948.fc13 Resolution| |ERRATA Last Closed| |2011-01-10 16:27:36
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-01-10 16:28:02 EST --- tkabber-plugins-0.11.1-3.svn1948.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|tkabber-plugins-0.11.1-3.sv |tkabber-plugins-0.11.1-3.sv |n1948.fc13 |n1948.fc14
package-review@lists.fedoraproject.org