Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ktp-accounts-kcm - KDE Configuration Module for Telepathy Instant Messaging Accounts
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Summary: Review Request: ktp-accounts-kcm - KDE Configuration Module for Telepathy Instant Messaging Accounts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm-0.3.0-1.... Description: KDE Configuration Module for Telepathy Instant Messaging Accounts
renaming telepathy-kde-0.1 stuff.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |784945 Blocks| |784939(kde-telepathy-0.3), | |656997(kde-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alekcejk@googlemail.com QAContact|extras-qa@fedoraproject.org |alekcejk@googlemail.com Flag| |fedora-review?
--- Comment #1 from nucleo alekcejk@googlemail.com 2012-02-06 22:19:22 EST --- name: ok summary: ok license: ok handling locale files: ok Obsoletes/Provides: ok
BuildRequires: telepathy-qt4-deve not needed because ktp-common-internals-devel requires it.
"rm -f %{buildroot}%{_kde4_libdir}/libkcmtelepathyaccounts.so" is actually not removes anything. Maybe it should be "rm -f %{buildroot}%{_kde4_libdir}/ libktpaccountskcminternal.so" and remove %{_kde4_libdir}/libktpaccountskcminternal.so?
ldd shows that libs installed in kde4 requires only versioned libktpaccountskcminternal.so.4.
This will fix rpmlint warning: ktp-accounts-kcm.i686: W: devel-file-in-non-devel-package /usr/lib/libktpaccountskcminternal.so
More detailed description can be added from README. There are many protocol dependencies: Requires: telepathy-butterfly Requires: telepathy-gabble Requires: telepathy-haze Requires: telepathy-idle Requires: telepathy-rakia Requires: telepathy-salut Requires: telepathy-sunshine
So maybe it makes sense to place every protocol in subpackage with corresponding dependency?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- QAContact|alekcejk@googlemail.com |extras-qa@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2012-02-07 09:08:39 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm-0.3.0-1....
%changelog * Tue Feb 07 2012 Rex Dieter rdieter@fedoraproject.org 0.3.0-2 - improve %%description - drop BR: telepathy-qt4-devel - omit libktpaccountskcminternal.so
Re: So maybe it makes sense to place every protocol in subpackage with corresponding dependency?
perhaps, but * currently its simplified to "just work", and follows how gnome/empathy does things * If we decide to do otherwise, that's a design decision I'd rather make as a team later, and (imo) shouldn't be considered a review blocker here and now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from nucleo alekcejk@googlemail.com 2012-02-07 09:29:57 EST --- APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|alekcejk@googlemail.com |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Bug 784944 depends on bug 784945, which changed state.
Bug 784945 Summary: Review Request: ktp-common-internals - Common internals for KDE Telepathy https://bugzilla.redhat.com/show_bug.cgi?id=784945
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Status|NEW |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2012-02-09 13:44:08 EST --- New Package SCM Request ======================= Package Name: ktp-common-internals Short Description: Common internals for KDE Telepathy Owners: jreznik rdieter Branches: f16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2012-02-09 13:45:21 EST --- copy-n-paste fail, let's try again,
New Package SCM Request ======================= Package Name: ktp-accounts-kcm Short Description: KDE Configuration Module for Telepathy Instant Messaging Accounts Owners: jreznik rdieter Branches: f16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-02-09 13:54:53 EST --- Git done (by process-git-requests).
Please take ownership of review BZs. Thanks!
Added f17.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com
--- Comment #7 from Kevin Kofler kevin@tigcc.ticalc.org 2012-02-09 17:20:49 EST --- You can't unassign yourself from an already approved review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784944
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-02-10 17:09:58
--- Comment #8 from Rex Dieter rdieter@math.unl.edu 2012-02-10 17:09:58 EST --- imported
package-review@lists.fedoraproject.org