Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pertusus@free.fr QAContact: fedora-package-review@redhat.com
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-DesktopEntry.... SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-DesktopEntry-... Description: This module is used to work with .desktop files. The format of these files is specified by the freedesktop "Desktp Entry" specification. See http://freedesktop.org/wiki/Standards_2fdesktop_2dentry_2dspec. For this module version 0.9.4 of the specification was used.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |210322 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
------- Additional Comments From miker5slow@grandecom.net 2006-10-12 12:24 EST ------- I was looking at the spec and then at: http://fedoraproject.org/wiki/Packaging/Perl and your spec doesnt have the provides stuff mentioned at the top, I wasnt sure if thats because it wasnt needed here or what. It does build fine in mock and rpmlint has nothing to say about it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
------- Additional Comments From pertusus@free.fr 2006-10-12 15:14 EST ------- If you refer to the requires and provides autodeps, it is only needed when package autodetected provides or requires are wrong. Those of the one I proposed seem right:
Provides: perl(File::DesktopEntry) = 0.02 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires: perl(:MODULE_COMPAT_5.8.8) perl(File::Spec) perl(strict)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |210320 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-10-14 15:56 EST ------- Michael, everything on http://fedoraproject.org/wiki/Packaging/Perl is either advisory or contingent on the faulure of some part of RPM's automatic dependency generation. RPM actually does a pretty good job of figuring out most Perl dependencies, and the resulting packages don't generally need much in the way of extraneous bits.
* source files match upstream: 9c97efa062c04bcb86a0a6a3707355d1 File-DesktopEntry-0.02.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(File::DesktopEntry) = 0.02 perl-File-DesktopEntry = 0.02-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(File::Spec) perl(strict) * %check is present and all tests pass: All tests successful. Files=2, Tests=10, 0 wallclock secs ( 0.06 cusr + 0.03 csys = 0.09 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210323
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From pertusus@free.fr 2006-10-17 17:32 EST ------- Thanks for that review too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-DesktopEntry - Object to handle .desktop files
https://bugzilla.redhat.com/show_bug.cgi?id=210323
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org