https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Bug ID: 2051069 Summary: Review Request: khealthcertificate - Handling of digital vaccination, test and recovery certificates. Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: justin.zobel@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spe... SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-21....
Description: Handling of digital vaccination, test and recovery certificates. Fedora Account System Username: justinz
Pagure URL: https://pagure.io/khealthcertificate_rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.e.fuller@gmx.de Assignee|nobody@fedoraproject.org |mark.e.fuller@gmx.de Doc Type|--- |If docs needed, set a value
--- Comment #1 from Mark E. Fuller mark.e.fuller@gmx.de --- Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Some additional things:
-the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}"
-are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #2 from Justin Zobel justin.zobel@gmail.com --- Requested changes made.
Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spe... SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-22....
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #3 from Mark E. Fuller mark.e.fuller@gmx.de --- Sorry about the delay in getting back to this.
As in https://bugzilla.redhat.com/show_bug.cgi?id=2051055,
%{_kf5_libdir}/*.so.*
Please add soversion number here to avoid accidental bumps: %{_kf5_libdir}/*.so.1* (or appropriate number if not 1)
I think that's everything
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #4 from Justin Zobel justin.zobel@gmail.com --- Not a problem. Updated as per request.
Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spe... SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-22....
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #5 from Mark E. Fuller mark.e.fuller@gmx.de --- Looks good - I approve
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/khealthcertificate
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2051073
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2051073 [Bug 2051073] Review Request: vakzination - Vakzination manages your health certificates like vaccination, test, and recovery certificates.
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b808a39e4b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fa30369522 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fa30369522 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fa30369522 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b808a39e4b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-02-27 04:08:33
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051069
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fa30369522 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org