Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Test-CheckChanges - Check that the Changes file matches the distribution
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Summary: Review Request: perl-Test-CheckChanges - Check that the Changes file matches the distribution Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-CheckChanges/branche...
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-CheckChanges/perl-Test-CheckC...
Description:
This module checks that your Changes file has an entry for the current version of the Module being tested. The version information for the distribution being tested is taken out of the Build data, or if that is not found, out of the Makefile. It then attempts to open, in order, a file with the name Changes or CHANGES. The Changes file is then parsed for version numbers. If one and only one of the version numbers matches, the test passes; otherwise the test fails. A message with the current version is printed if the test passes; otherwise diagnostic messages are printed to help explain the failure.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mariobl@freenet.de AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review?
--- Comment #1 from Mario Blättermann mariobl@freenet.de 2011-05-06 15:06:23 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3055110
$ rpmlint -v * perl-Test-CheckChanges.noarch: I: checking perl-Test-CheckChanges.noarch: I: checking-url http://search.cpan.org/dist/Test-CheckChanges/ (timeout 10 seconds) perl-Test-CheckChanges.src: I: checking perl-Test-CheckChanges.src: I: checking-url http://search.cpan.org/dist/Test-CheckChanges/ (timeout 10 seconds) perl-Test-CheckChanges.src: E: unknown-key GPG#b56a8bac perl-Test-CheckChanges.src: I: checking-url http://search.cpan.org/CPAN/authors/id/G/GA/GAM/Test-CheckChanges-0.14.tar.g... (timeout 10 seconds) perl-Test-CheckChanges.spec: I: checking-url http://search.cpan.org/CPAN/authors/id/G/GA/GAM/Test-CheckChanges-0.14.tar.g... (timeout 10 seconds) 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
No errors so far. The mentioned error comes from the srpm which is signed with an unknown GPG key, doesn't matter.
The package perl-test-simple is available in F14 as v0.98. Do we really need the patch here? Which current distros (Fedora and EPEL) ships an older version than 0.88?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #2 from Paul Howarth paul@city-fan.org 2011-05-06 15:14:28 EDT --- Fedora 10 (and hence EPEL 4/5) have versions older than that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Mario Blättermann mariobl@freenet.de 2011-05-07 13:12:47 EDT --- --------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 90f83e10cd1045009db3e7c05947bf0c Test-CheckChanges-0.14.tar.gz 90f83e10cd1045009db3e7c05947bf0c Test-CheckChanges-0.14.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts.
----------------
PACKAGE APPROVED
----------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Paul Howarth paul@city-fan.org 2011-05-07 14:50:06 EDT --- New Package SCM Request ======================= Package Name: perl-Test-CheckChanges Short Description: Check that the Changes file matches the distribution Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-13 F-14 F-15 InitialCC: perl-sig
Thanks for the review Mario.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2011-05-10 12:05:42 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-05-11 04:38:04 EDT --- perl-Test-CheckChanges-0.14-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-05-11 04:38:12 EDT --- perl-Test-CheckChanges-0.14-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-05-11 04:38:19 EDT --- perl-Test-CheckChanges-0.14-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-05-11 04:38:26 EDT --- perl-Test-CheckChanges-0.14-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-05-11 04:38:34 EDT --- perl-Test-CheckChanges-0.14-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #11 from Paul Howarth paul@city-fan.org 2011-05-11 04:42:44 EDT --- EL-6 build is failing due to missing Test::Exception, which should be in RHEL-6 server optional channel.
https://fedorahosted.org/rel-eng/ticket/4604
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-05-13 10:23:45 EDT --- perl-Test-CheckChanges-0.14-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Test-CheckChanges-0.14-2.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-05-19 01:00:12 EDT --- perl-Test-CheckChanges-0.14-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-05-24 22:24:53 EDT --- perl-Test-CheckChanges-0.14-2.fc13 has been pushed to the Fedora 13 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-05-24 22:33:06 EDT --- perl-Test-CheckChanges-0.14-2.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-05-28 17:32:02 EDT --- perl-Test-CheckChanges-0.14-2.el4 has been pushed to the Fedora EPEL 4 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2011-05-28 17:33:21 EDT --- perl-Test-CheckChanges-0.14-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2011-05-28 17:35:01 EDT --- perl-Test-CheckChanges-0.14-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702692
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Test-CheckChanges-0.14 | |-2.fc16 Resolution| |NEXTRELEASE Last Closed| |2011-06-02 06:09:41
package-review@lists.fedoraproject.org