https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Bug ID: 1970460 Summary: Review Request: goocanvas2-cairotypes - Bridge between GooCanvas2 and Cairo types Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@netcom-mail.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/goocanvas2-cairotypes.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/goocanvas2-cairotypes-0.001-1... Description: Bridge between GooCanvas2 and Cairo types Fedora Account System Username: martinkg
rpmlint -i -v goocanvas2-cairotypes.spec /home/martin/rpmbuild/SRPMS/goocanvas2-cairotypes-0.001-1.fc34.src.rpm /home/martin/rpmbuild/RPMS/x86_64/goocanvas2-cairotypes-0.001-1.fc34.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/goocanvas2-cairotypes-debuginfo-0.001-1.fc34.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/goocanvas2-cairotypes-debugsource-0.001-1.fc34.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/goocanvas2-cairotypes-devel-0.001-1.fc34.x86_64.rpm goocanvas2-cairotypes.spec: I: checking goocanvas2-cairotypes.spec: I: checking-url https://cpan.metacpan.org/authors/id/A/AS/ASOKOLOV/GooCanvas2-CairoTypes-0.0... (timeout 10 seconds) goocanvas2-cairotypes.src: I: checking goocanvas2-cairotypes.src: I: checking-url https://metacpan.org/dist/GooCanvas2-CairoTypes (timeout 10 seconds) goocanvas2-cairotypes.src: I: checking-url https://cpan.metacpan.org/authors/id/A/AS/ASOKOLOV/GooCanvas2-CairoTypes-0.0... (timeout 10 seconds) goocanvas2-cairotypes.x86_64: I: checking goocanvas2-cairotypes.x86_64: I: checking-url https://metacpan.org/dist/GooCanvas2-CairoTypes (timeout 10 seconds) goocanvas2-cairotypes.x86_64: W: library-not-linked-against-libc /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so goocanvas2-cairotypes-debuginfo.x86_64: I: checking goocanvas2-cairotypes-debuginfo.x86_64: I: checking-url https://metacpan.org/dist/GooCanvas2-CairoTypes (timeout 10 seconds) goocanvas2-cairotypes-debugsource.x86_64: I: checking goocanvas2-cairotypes-debugsource.x86_64: I: checking-url https://metacpan.org/dist/GooCanvas2-CairoTypes (timeout 10 seconds) goocanvas2-cairotypes-devel.x86_64: I: checking goocanvas2-cairotypes-devel.x86_64: I: checking-url https://metacpan.org/dist/GooCanvas2-CairoTypes (timeout 10 seconds) goocanvas2-cairotypes-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
5 packages and 1 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Shouldn't this be named perl-goocanvas2-cairotypes?
Also ask help from the perl-sig for review, I am no specialist at it.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #2 from MartinKG mgansser@netcom-mail.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/perl-goocanvas2-cairotypes.sp... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/perl-goocanvas2-cairotypes-0....
%changelog * Thu Jun 17 2021 Martin Gansser martinkg@fedoraproject.org - 0.001-2 - Rename package to perl-goocanvas2-cairotypes
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
MartinKG mgansser@netcom-mail.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |goocanvas2-cairotypes - |perl-goocanvas2-cairotypes |Bridge between GooCanvas2 |- Bridge between GooCanvas2 |and Cairo types |and Cairo types
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com
--- Comment #3 from Petr Pisar ppisar@redhat.com --- No. This package should be called perl-GooCanvas2-CairoTypes because an upstream is calls it GooCanvas2-CairoTypes.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #4 from MartinKG mgansser@netcom-mail.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/perl-GooCanvas2-CairoTypes.sp... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/perl-GooCanvas2-CairoTypes-0....
%changelog * Tue Jun 29 2021 Martin Gansser martinkg@fedoraproject.org - 0.001-3 - Rename package to perl-GooCanvas2-CairoTypes
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
MartinKG mgansser@netcom-mail.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-goocanvas2-cairotypes |perl-GooCanvas2-CairoTypes |- Bridge between GooCanvas2 |- Bridge between GooCanvas2 |and Cairo types |and Cairo types
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #5 from MartinKG mgansser@netcom-mail.de --- needed by shutter https://bugzilla.redhat.com/show_bug.cgi?id=1970748
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #6 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 00478eda62bfb80393635e0c5eaa86cf43646e74df1ec61f9fac58f4792e8deabeede3f6dbfbaf8844c850f3ca729f3f27090449670f9eeeafcf2ec3ccd316c0) is original. Ok.
FIX: Do not use obsolete %filter_provides_in macro. You can use %__provides_exclude_from https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/. But it should not be necessary because these provides are not generated.
Summary verified from lib/GooCanvas2/CairoTypes.pm. Ok.
FIX: %description must be sentence. And it should provide better explanation than Summary. I recommend DESCRIPTION text found in lib/GooCanvas2/CairoTypes.pm POD.
FIX: The License value is wrong. E.g. lib/GooCanvas2/CairoTypes.pm file is "GPL+ or Artistic": This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself, either Perl version 5.22.3 or, at your option, any later version of Perl 5 you may have available. A similar declaration can be found in README and LICENSE files.
FIX: There is no point in "%exclude %dir %{perl_vendorarch}/auto/". The directory is not packaged. FIX: Do not do "%exclude %{perl_vendorarch}/perllocal.pod". That's achieved with "Makefile.PL NO_PERLLOCAL=1". FIX: Package the excluded %{_mandir}/man3/GooCanvas2::CairoTypes.3pm.gz file in devel subpackage. FIX: Remove "BuildRequires: perl-macros". You do not call any macro from that package.
FIX: Build-require 'perl(strict)' (Makefile.PL:5). FIX: Build-require 'perl(warnigs)' (Makefile.PL:6).
'perl(Gtk3)' is not used at tests. Ok. 'perl(XSLoader)' is not used at tests. Ok.
FIX: Build-require 'perl(File::Spec)' (t/00-report-prereqs.t:11).
FIX: Do not require "perl(lib)". It's nowhere used.
All tests pass. Ok.
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-3.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-3.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debugsource.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-devel.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 ../../../.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 =========================== 5 packages and 1 specfiles checked; 1 errors, 5 warnings, 1 badness; has taken 1.1 s ========================== rpmlint is Ok.
The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=71570148). Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib/.build-id/be lrwxrwxrwx 1 root root 80 Jul 9 09:13 /usr/lib/.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 -> ../../../../usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/GooCanvas2 -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2 drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes -rwxr-xr-x 1 root root 15232 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/share/doc/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 85 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/Changes -rw-r--r-- 1 root root 1966 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/README drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/share/licenses/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 18331 Feb 19 01:34 /usr/share/licenses/perl-GooCanvas2-CairoTypes/LICENSE
$ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm FIX: There is no point in packaging CairoTypes.pm file twice. Do not produce perl-GooCanvas2-CairoTypes-devel subpackage. FIX: You are missing GooCanvas2::CairoTypes.3pm.gz file.
$ rpm -q --requires -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 glibc >= 2.33.9000-39.fc35 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libcairo-gobject.so.2()(64bit) 1 libgoocanvas-2.0.so.9()(64bit) 1 libperl.so.5.34()(64bit) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Gtk3) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 1 perl(Gtk3) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: "Requires: %{tarname}%{?_isa} = %{version}-%{release}" at devel subpackage is wrong. You want "%{name}{?isa}...".
$ rpm -q --provides -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 1 perl(GooCanvas2::CairoTypes) = 0.001 1 perl-GooCanvas2-CairoTypes = 0.001-3.fc35 1 perl-GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 FIX: Do not provide "%{tarname}%{?_isa} = %{version}-%{release}". In Fedora we call packages 'perl-Foo' and Perl modules 'perl(Foo)'. This artifical Provide only polutes Fedora repository.
$ rpm -q --provides -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 perl(GooCanvas2::CairoTypes) = 0.001 1 perl-GooCanvas2-CairoTypes-devel = 0.001-3.fc35 1 perl-GooCanvas2-CairoTypes-devel(x86-64) = 0.001-3.fc35 Binary provides are Ok.
$ resolvedeps f35-build ../RPMS/x86_64/perl-GooCanvas2-CairoTypes{,-devel}-0.001-3.fc35.x86_64.rpm Binary dependencies are resolvable. Ok.
Please correct all 'FIX' items and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #7 from MartinKG mgansser@netcom-mail.de --- Thanks for the review.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/perl-GooCanvas2-CairoTypes.sp... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/perl-GooCanvas2-CairoTypes-0....
%changelog * Fri Jul 09 2021 Martin Gansser martinkg@fedoraproject.org - 0.001-4 - Dropped %%filter_provides_in macro - Fixed %%description must be sentence - Fixed license value to "GPL+ or Artistic" - Include unpacked directory %%dir %%{perl_vendorarch}/auto/ - Do not do "%exclude %%{perl_vendorarch}/perllocal.pod That's achieved with "Makefile.PL NO_PERLLOCAL=1" - Include %%{_mandir}/man3/GooCanvas2::CairoTypes.3pm.gz file in devel subpackage - Remove BR perl-macros - Add BR perl(strict) - Add BR perl(warnigs) - Add BR perl(File::Spec) - Remove BR perl(lib) - Corrected Requires to %%{name}%%{?_isa}
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #8 from Petr Pisar ppisar@redhat.com --- TODO: You can remove the parenthesis from the License value. TODO: Do not provide "%{name}%{?_isa} = %{version}-%{release}" explicitly. It's is created automatically.
The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=71589206). Ok.
$ rpmlint perl-GooCanvas2-CairoTypes.spec ../SRPMS/perl-GooCanvas2-CairoTypes-0.001-4.fc35.src.rpm ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-* ========================================================== rpmlint session starts ========================================================= rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-4.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-4.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debugsource.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2 ../../../.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2 =========================== 5 packages and 1 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.9 s ========================== rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-4.fc35.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/lib/.build-id/b7 lrwxrwxrwx 1 root root 80 Jul 9 15:42 /usr/lib/.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2 -> ../../../../usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/lib64/perl5/vendor_perl/GooCanvas2 -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2 drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes -rwxr-xr-x 1 root root 15232 Jul 9 15:42 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/share/doc/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 85 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/Changes -rw-r--r-- 1 root root 1966 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/README drwxr-xr-x 2 root root 0 Jul 9 15:42 /usr/share/licenses/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 18331 Feb 19 01:34 /usr/share/licenses/perl-GooCanvas2-CairoTypes/LICENSE -rw-r--r-- 1 root root 2052 Jul 9 15:42 /usr/share/man/man3/GooCanvas2::CairoTypes.3pm.gz
$ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-4.fc35.x86_64.rpm -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm -rw-r--r-- 1 root root 2052 Jul 9 15:42 /usr/share/man/man3/GooCanvas2::CairoTypes.3pm.gz
FIX: The devel subpackage is a subset of the main package. Please do not create the devel subpackage. It has no meaning.
$ resolvedeps f35-build ../RPMS/x86_64/perl-GooCanvas2-CairoTypes{,-devel}-0.001-4.fc35.x86_64.rpm Binary dependencies are resolvable. Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item, consider fixing the 'TODO' items, and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #9 from MartinKG mgansser@netcom-mail.de --- New package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/perl-GooCanvas2-CairoTypes.sp... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/perl-GooCanvas2-CairoTypes-0....
%changelog * Fri Jul 09 2021 Martin Gansser martinkg@fedoraproject.org - 0.001-5 - Remove the parenthesis from the License value - Remove Provides it's is created automatically - Do not create a devel subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #10 from Petr Pisar ppisar@redhat.com --- $ rpmlint perl-GooCanvas2-CairoTypes.spec ../SRPMS/perl-GooCanvas2-CairoTypes-0.001-5.fc35.src.rpm ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-* ========================================================== rpmlint session starts ========================================================= rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-5.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-5.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debugsource.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/fa/8ab52c7e78d30b07ca8ac677d435ce6d818498 ../../../.build-id/fa/8ab52c7e78d30b07ca8ac677d435ce6d818498 =========================== 4 packages and 1 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.8 s ========================== rpmlint is Ok.
$ rpm -q --requires ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-5.fc35.x86_64.rpm | sort -f | uniq -c 1 glibc >= 2.33.9000-39.fc35 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libcairo-gobject.so.2()(64bit) 1 libgoocanvas-2.0.so.9()(64bit) 1 libperl.so.5.34()(64bit) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Gtk3) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok.
$ rpm -q --provides ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-5.fc35.x86_64.rpm | sort -f | uniq -c 1 perl(GooCanvas2::CairoTypes) = 0.001 1 perl-GooCanvas2-CairoTypes = 0.001-5.fc35 1 perl-GooCanvas2-CairoTypes(x86-64) = 0.001-5.fc35 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-5.fc35.x86_64.rpm Binary dependencies are resolvable. Ok.
The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=71747341). Ok.
Thanks for the hard work on this package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #11 from MartinKG mgansser@netcom-mail.de --- Thanks for your excellent support with the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #12 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GooCanvas2-CairoTypes
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-ad40526fe1 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ad40526fe1
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
MartinKG mgansser@netcom-mail.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2021-07-12 15:01:34
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-ad40526fe1 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-ad40526fe1 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ad40526fe1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-8c9daf8c91 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8c9daf8c91 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8c9daf8c91
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1970748
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1970748 [Bug 1970748] shutter-0.97 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-ad40526fe1 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1970460
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-8c9daf8c91 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org