https://bugzilla.redhat.com/show_bug.cgi?id=2256466
Bug ID: 2256466 Summary: Review Request: kf6-kapidox - KDE Frameworks 6 Tier 4 scripts and data for building API documentation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loise@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/loise/kf6-API/fedora-rawh... SRPM URL: https://download.copr.fedorainfracloud.org/results/loise/kf6-API/fedora-rawh... Description: KDE Frameworks 6 Tier 4 scripts and data for building API documentation Fedora Account System Username: loise
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
loise@kde.org loise@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcdeop@fedoraproject.org, | |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from loise@kde.org loise@kde.org --- I've made a copr and now adding doc packages to KF6, starting with an experiment on kf6-bluez-qt which gave the desired results.
I can install kf6-bluez-qt-doc and it automatically shows up in Qt Creator for me.
The thing missing will be the cross-links later to the Qt documentation as there is none yet in Fedora for Qt6 (which is another item on my todo)
If the package is accepted and available, I want to add the changes to the KF6 packages adding a doc package for each one to be done (already doing so for later use and testing)
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #2 from loise@kde.org loise@kde.org --- https://copr.fedorainfracloud.org/coprs/loise/kf6-API/builds/
kf6-bluez-qt as first example here:
https://copr.fedorainfracloud.org/coprs/loise/kf6-API/build/6847952/
SPEC file: https://download.copr.fedorainfracloud.org/results/loise/kf6-API/fedora-rawh...
So, basically all kf6 packages need following additons:
BuildRequires: kf6-kapidox + BuildRequires: kf6-*-doc where the accoring dependencies have QCH files for crosslinks
%package doc Summary: Developer Documentation files for %{name} %description doc Developer Documentation files for %{name} for use with KDevelop or QtCreator.
%{cmake_kf6} \ -DBUILD_QCH:BOOL=ON \
%files doc %{_qt6_docdir}/KF6BluezQt.qch %{_qt6_docdir}/KF6BluezQt.tags
where * would last.
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #3 from loise@kde.org loise@kde.org --- new SPEC and SRPM:
SPEC file: https://download.copr.fedorainfracloud.org/results/loise/kf6-API/fedora-rawh... SRPM file: https://download.copr.fedorainfracloud.org/results/loise/kf6-API/fedora-rawh...
Changes:
Source0 URL http: -> https:
Fixed changelog entry 2023 -> 2024
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |farchord@gmail.com
--- Comment #4 from Steve Cossette farchord@gmail.com --- 1- Remove all build requirements except for python3-devel and kf6-filesystem (kf6-rpm-macros is included in that, thus not needed here either)
2- Add the following build requirements, used for the import test: # Test dependencies: BuildRequires: python3dist(pytest) BuildRequires: python3dist(gv)
3- Add the following right after the %prep section, per https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/:
%generate_buildrequires %pyproject_buildrequires
4- %build section should only contain: %pyproject_wheel
5- %install section should only contain the following: %pyproject_install %pyproject_save_files kapidox
6- Some tests should be added in %check. Seems the meager test(s) in this package dont really work with %tox or %pytest, and the test script itself don't run with python. So we basically can only do an import test. Add a %check section, and add this in it: %pyproject_check_import
7- Change %files to: %files -f %{pyproject_files}
8- Remove the following from %files: %{python3_sitelib}/kapidox %{python3_sitelib}/kapidox-%{version}-py*.egg-info
9- Change licensing to SPDX: BSD-2-Clause AND CC0-1.0 AND LGPL-3.0-or-later
That should do it.
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://invent.kde.org/fram | |eworks/%{framework}
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6848301 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2006848 --> https://bugzilla.redhat.com/attachment.cgi?id=2006848&action=edit The .spec file difference from Copr build 6848301 to 6848302
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6848302 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #8 from Steve Cossette farchord@gmail.com --- After speaking with Loise about this, I'll be taking over this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
--- Comment #9 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kapidox/kf6-kapidox.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kapidox/kf6-kapidox-5.247.0-1....
Updated spec with Fedora packaging directives' instructions
https://bugzilla.redhat.com/show_bug.cgi?id=2256466
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed| |2024-01-04 12:32:47
--- Comment #10 from Steve Cossette farchord@gmail.com ---
*** This bug has been marked as a duplicate of bug 2256766 ***
package-review@lists.fedoraproject.org