https://bugzilla.redhat.com/show_bug.cgi?id=1984210
Bug ID: 1984210 Summary: Review Request: build-constraints-rpm-macros - RPM macros for build constraints Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros.sp... SRPM URL: https://salimma.fedorapeople.org/specs/admin/build-constraints-rpm-macros-1-... Description: This package contains macros to constraint resource use during the build process.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1982748 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1982748 [Bug 1982748] Memory Constraints macros for RPM
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Review notes:
- Packaging follows naming guidelines - Package licensing is indicated correctly - Packaging builds and installs - No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- so this is basically a bit simplified from the Suse definitions in https://build.opensuse.org/package/view_file/openSUSE:Factory/memory-constra..., which was in turn based on the Ceph definition in https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/ceph.spec
- removed the cruft for disabling parallelism; this makes sense for Ceph but does not make sense in the Suse macro, since the setting to control it was automatically computed instead of user-specified - any spec can disable parallelism as usual, by overriding `_smp_build_ncpus` - like Ceph, but unlike the Suse definition, use physical memory and not physical+swap. We don't want swap thrashing during a build - override _smp_build_ncpus instead of _smp_mflags (which is just -j%{_smp_build_ncpus} anyway)
Thanks Neal!
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- $ fedpkg request-repo build-constraints-rpm-macros 1984210 https://pagure.io/releng/fedora-scm-requests/issue/35830
https://bugzilla.redhat.com/show_bug.cgi?id=1984210
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/build-constraints-rpm-macros
package-review@lists.fedoraproject.org