https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Bug ID: 2210485 Summary: Review Request: golang-github-minio-highwayhash -Native Go version of HighwayHash Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mark.e.fuller@gmx.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... Description: Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. Able to process over 10 GB/sec on a single core on Intel CPUs - https://en.wikipedia.org/wiki/HighwayHash Fedora Account System Username: fuller
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Status|NEW |ASSIGNED CC| |mikel@olasagasti.info
--- Comment #1 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Two issues with this spec:
golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. Able to process over 10 GB/sec on a single core on Intel CPUs - https://en.wikipedia.org/wiki/HighwayHash
Also, not sure if including URLs in description is a good idea.
And more important:
BuildError: The following noarch package built differently on different architectures: golang-github-minio-highwayhash-devel-1.0.2-1.fc39.noarch.rpm rpmdiff output was: removed REQUIRES golang(golang.org/x/sys/cpu)
You can check at https://koji.fedoraproject.org/koji/taskinfo?taskID=101901699
Look at golang-github-aead-chacha20.spec or golang-x-crypto.spec to see how this can be fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #2 from Mark E. Fuller mark.e.fuller@gmx.de --- Updated to fix both issues - thanks for catching these:
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Both, the spec file and the spec file in srpm are the same as the old ones.
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #4 from Mark E. Fuller mark.e.fuller@gmx.de --- What am I doing... Sorry about that and thanks for your patience
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. golang-github-minio-highwayhash-devel.noarch: W: summary-ended-with-dot Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM.
Fix those and I'll approve the package.
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #6 from Mark E. Fuller mark.e.fuller@gmx.de --- Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mark.e.fuller@gmx | |.de)
--- Comment #7 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Did you remove the fix for "golang(golang.org/x/sys/cpu)"?
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mark.e.fuller@gmx | |.de) |
--- Comment #8 from Mark E. Fuller mark.e.fuller@gmx.de --- There was an issue with my files syncing and I lost some work - sorry about missing that
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #9 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-minio-highway |golang-github-minio-highway |hash -Native Go version of |hash - Native Go version of |HighwayHash |HighwayHash
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
--- Comment #10 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-minio-highwayhash
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0ec75909f7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0ec75909f7
https://bugzilla.redhat.com/show_bug.cgi?id=2210485
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-06-11 19:49:00
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0ec75909f7 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org