Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Summary: Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jreznik@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap-1.7-1.fc14.src.rpm Description: The SOAP (Simple Object Access Protocol) library uses the XML standard for describing how to exchange messages. Its primary usage is to invoke web services and get responses from Qt-based applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews)
--- Comment #1 from Jaroslav Reznik jreznik@redhat.com 2011-02-22 08:58:18 EST --- rpmlint qtsoap.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint ../RPMS/x86_64/qtsoap-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
This package is needed for herqq (hupnp) which currently bundles own copy of qtsoap (it's intention of qtsoap developers). The final dependency is kio-upnp-ms (to be packaged).
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2857314
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |680174
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #2 from Jaroslav Reznik jreznik@redhat.com 2011-05-19 11:56:59 EDT --- spec URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap-2.7-1.fc14.src.rpm
Fixed version.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Trever Fischer wm161@wm161.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wm161@wm161.net
--- Comment #3 from Trever Fischer wm161@wm161.net 2011-05-19 12:05:42 EDT --- Not a review, but a brief comment: the library should be installed as 'libqtsoap', not 'libQtSolutions_SOAP', for consistency with the package name. Or vice-versa, calling the package 'qtsolutions-soap'.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-05-19 13:54:09 EDT --- I can review this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+
--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2011-05-19 14:04:20 EDT ---
licensing: OK
scriptlets: OK
naming: OK
URL provided doesn't work for me, please find something better. Not a blocker.
rpmlint: clean, OK
builds/installs OK
In a perfect world, I'd like to see comment #3 addressed too, wrt keeping library naming more consistent, using something from trever's .spec he showed us earlier today: %build echo 'yes' | \ ./configure -library
echo "QTSOAP_LIBNAME = $$qtLibraryTarget(qtsoap)" >> common.pri echo "VERSION=%{version}" >> common.pri
qmake-qt4
make %{?_smp_mflags}
But, I'll leave it up to you on how best to resolve that (with some potential upstream poking). not a blocker.
Otherwise, looks good, APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |qtsoap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #6 from Jaroslav Reznik jreznik@redhat.com 2011-05-20 10:44:13 EDT --- (In reply to comment #5)
licensing: OK
scriptlets: OK
naming: OK
URL provided doesn't work for me, please find something better. Not a blocker.
rpmlint: clean, OK
builds/installs OK
In a perfect world, I'd like to see comment #3 addressed too, wrt keeping library naming more consistent, using something from trever's .spec he showed us earlier today: %build echo 'yes' | \ ./configure -library
echo "QTSOAP_LIBNAME = $$qtLibraryTarget(qtsoap)" >> common.pri echo "VERSION=%{version}" >> common.pri
qmake-qt4
make %{?_smp_mflags}
But, I'll leave it up to you on how best to resolve that (with some potential upstream poking). not a blocker.
Otherwise, looks good, APPROVED
There's no upstream anymore but I'll try to incorporate this change into my fedora qt-soap branch.
Thanks for review, good spot guys.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2011-07-06 11:19:44 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #8 from Jaroslav Reznik jreznik@redhat.com 2011-07-07 04:31:03 EDT --- (In reply to comment #7)
ping?
Rex, I'd like to implement suggested enhancements but I was busy... So probably I should just import it in the current state...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #9 from Jaroslav Reznik jreznik@redhat.com 2011-07-07 05:22:10 EDT --- New Package SCM Request ======================= Package Name: qtsoap Short Description: The Simple Object Access Protocol Qt-based client side library Owners: jreznik rdieter kkofler than Branches: f14 f15 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2011-07-07 06:09:47 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(wm161@wm161.net)
--- Comment #11 from Jaroslav Reznik jreznik@redhat.com 2011-07-14 09:23:46 EDT --- Trever, could you share your SPEC file with me (the one Rex is talking about)?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|needinfo?(wm161@wm161.net) | Last Closed| |2011-07-19 05:02:37
--- Comment #12 from Jaroslav Reznik jreznik@redhat.com 2011-07-19 05:02:37 EDT --- imported & built for rawhide
package-review@lists.fedoraproject.org