Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rygel - A UPnP v2 Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Summary: Review Request: rygel - A UPnP v2 Media Server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pbrobinson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Depends on: 454668 Estimated Hours: 0.0 Classification: Fedora
SPEC: http://pbrobinson.fedorapeople.org/rygel.spec SRPM: http://pbrobinson.fedorapeople.org/rygel-0.2.2-1.fc10.src.rpm
Rygel is an implementation of the UPnP MediaServer V 2.0 specification that is specifically designed for GNOME. It is based on GUPnP and is written (mostly) in Vala language. The project was previously known as gupnp-media-server.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Michel Alexandre Salim michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel.sylvan@gmail.com AssignedTo|nobody@fedoraproject.org |michel.sylvan@gmail.com Flag| |fedora-review?
--- Comment #1 from Michel Alexandre Salim michel.sylvan@gmail.com 2009-03-02 13:29:10 EDT --- Looks like it's missing some build dependencies:
gupnp-vala GConf2-devel dbus-glib-devel e2fsprogs-devel
The *.so files are presumably for internal use only? (thus, it's fine that ldconfig is not called)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #2 from Peter Robinson pbrobinson@gmail.com 2009-03-02 14:43:16 EDT --- SRPM: http://pbrobinson.fedorapeople.org/rygel-0.2.2-2.fc10.src.rpm
Updated. Spec is same location. I thought I had added at least some of those! The .so files are internal plugins so are only for internal.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #3 from Michel Alexandre Salim michel.sylvan@gmail.com 2009-03-02 15:36:06 EDT --- OK, will review. Would you care to do a swap, by the way? This should be small and quick to do:
https://bugzilla.redhat.com/show_bug.cgi?id=487938
Thanks in advance!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #4 from Michel Alexandre Salim michel.sylvan@gmail.com 2009-03-02 15:47:21 EDT --- rpmlint looks clean. For some reason, my F-10 machine is not generating debuginfo packages, so I'm getting warnings about unstripped binaries and libraries. Will test with Koji once gupnp-vala lands in Rawhide.
Let's try and look the other issues before then. The log from running rygel is attached below. Looks like: DVB plugin: - Does not provide an icon, as expected. probably harmless, it's an early release after all - Some DBus problem?
Tracker: - those isassassbasbii log messages are presumably debugging stuff, but I'm not sure where they're coming from (they do not appear in the source).
Is there a way to verify that this package is functional?
** (rygel:28698): DEBUG: rygel-plugin-loader.vala:106: Loaded plugin: '/usr/lib64/rygel-1.0/librygel-dvb.so'
** (rygel:28698): DEBUG: rygel-media-server-factory.vala:293: No icon provided by DVB.
** (rygel:28698): CRITICAL **: rygel-dvb-root-container.vala:60: Failed to fetch device groups: The name org.gnome.DVB was not provided by any .service files
** (rygel:28698): DEBUG: rygel-plugin-loader.vala:106: Loaded plugin: '/usr/lib64/rygel-1.0/librygel-media-tracker.so'
** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Images': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist
** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Music': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist
** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Videos': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Bug 488096 depends on bug 454668, which changed state.
Bug 454668 Summary: Review Request: gupnp-vala - vala bindings for gupnp https://bugzilla.redhat.com/show_bug.cgi?id=454668
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Michel Alexandre Salim michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(pbrobinson@gmail. | |com)
--- Comment #5 from Michel Alexandre Salim michel.sylvan@gmail.com 2009-03-24 15:21:03 EDT --- ping? it looks like Rawhide's gupnp-vala is older than F-10's (it's still not noarch). If you could rebuild an up-to-date version then we can get this review underway -- thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(pbrobinson@gmail. | |com) |
--- Comment #6 from Peter Robinson pbrobinson@gmail.com 2009-03-24 20:47:08 EDT --- I thought that the noarch feature was one that was introduced with F11/rawhide so when I pushed it the F10 I removed that option, other than that the package should be the same.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #7 from Peter Robinson pbrobinson@gmail.com 2009-04-08 08:11:52 EDT --- Any update on this review? It all builds fine in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1285122
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #8 from Peter Robinson pbrobinson@gmail.com 2009-04-12 17:44:06 EDT --- Ping. I'd like to get this into rawhide in time for F11 feature freeze :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #9 from Peter Robinson pbrobinson@gmail.com 2009-04-19 16:59:40 EDT --- Ping.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #10 from Peter Robinson pbrobinson@gmail.com 2009-05-13 07:17:43 EDT --- Michel, Any update?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #11 from Christopher Aillon caillon@redhat.com 2009-05-13 17:27:44 EDT --- It has been one over one month. Peter, if you have not sent Michel direct mail yet, please do so. If you do not receive a response in a week's time, please re-assign this to me. I have strong interest in this package as I have DLNA hardware.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #12 from Peter Robinson pbrobinson@gmail.com 2009-05-13 17:38:49 EDT --- Email sent.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|michel.sylvan@gmail.com |caillon@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(caillon@redhat.co | |m)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #13 from Peter Robinson pbrobinson@gmail.com 2009-06-03 12:32:03 EDT --- New SPEC/SRPM for a new upstream release SPEC: http://pbrobinson.fedorapeople.org/rygel.spec SRPM: http://pbrobinson.fedorapeople.org/rygel-0.3-1.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #14 from Peter Robinson pbrobinson@gmail.com 2009-06-03 19:31:24 EDT --- koji build on F12 rawhide is here http://koji.fedoraproject.org/koji/taskinfo?taskID=1392690
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Christopher Aillon caillon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(caillon@redhat.co | |m) |
--- Comment #15 from Christopher Aillon caillon@redhat.com 2009-06-04 11:18:17 EDT --- Whoops, missed you assigning this to me. Was waiting on you to actually ping me. Will add this to my todo list now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Lennart Poettering lpoetter@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lpoetter@redhat.com
--- Comment #16 from Lennart Poettering lpoetter@redhat.com 2009-06-04 18:05:08 EDT --- Would love to see this in Rawhide. Would make it much easier for me to test the new UPnP code in PulseAudio...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #17 from Christopher Aillon caillon@redhat.com 2009-06-05 15:07:37 EDT --- On F11, I see
error: Failed build dependencies: vala-devel >= 0.7 is needed by rygel-0.3-1.fc11.src gupnp-vala >= 0.5.4 is needed by rygel-0.3-1.fc11.src
I see there's a new version of vala in updates-testing, so grabbing that. Do you have a newer version of gupnp-vala available?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #18 from Peter Robinson pbrobinson@gmail.com 2009-06-05 15:29:32 EDT --- (In reply to comment #17)
On F11, I see
error: Failed build dependencies: vala-devel >= 0.7 is needed by rygel-0.3-1.fc11.src gupnp-vala >= 0.5.4 is needed by rygel-0.3-1.fc11.src
I see there's a new version of vala in updates-testing, so grabbing that. Do you have a newer version of gupnp-vala available?
Not yet as I'm waiting for it all to push out, haven't had a chance to get the new vala builds tagged into build override. The f12 built one will function just fine on F11 though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #19 from Christopher Aillon caillon@redhat.com 2009-06-05 16:35:55 EDT --- Okay, grabbing it, but I just tagged the newer vala into override if you want to get the gupnp builds done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Christopher Aillon caillon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #20 from Christopher Aillon caillon@redhat.com 2009-06-05 17:06:14 EDT --- rpmlint output as required by package review guidelines:
rygel.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/rygel.schemas rygel-devel.x86_64: W: no-documentation
MUST fix:
N/A. Package meets all requirements in the MUST section of the Package Review guidelines as of Fri, Jun 5, 2009.
SHOULD fix:
Please use the most preferred buildroot tag per http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Additional Suggestion: Please change your comment about the .la files. .la files are not static libraries, they are libtool archives.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #21 from Peter Robinson pbrobinson@gmail.com 2009-06-05 17:32:12 EDT --- Thanks Christopher, will fix up should and suggestions on commit.
New Package CVS Request ======================= Package Name: rygel Short Description: A UPnP v2 Media Server Owners: pbrobinson Branches: F-11 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #22 from Jason Tibbitts tibbs@math.uh.edu 2009-06-05 18:07:43 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
--- Comment #23 from Peter Robinson pbrobinson@gmail.com 2009-06-05 18:27:02 EDT --- Imported into cvs. F-12 build as follows:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1395963
filed rel-eng ticket 1914 for gupnp-vala dep for F-11 build
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488096
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #24 from Peter Robinson pbrobinson@gmail.com 2009-06-11 17:17:11 EDT --- Added to F11 as an update https://admin.fedoraproject.org/updates/rygel-0.3-1.fc11
package-review@lists.fedoraproject.org