https://bugzilla.redhat.com/show_bug.cgi?id=831871
Bug ID: 831871 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: openstack-swift-plugin-swift3 - The swift3 plugin for Openstack Swift Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: zaitcev@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3.spec-1.0.... SRPM URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3-1.0.0-201... Description: The swift3 plugin permits accessing Openstack Swift via the Amazon S3 API.
Fedora Account System Username: zaitcev
https://bugzilla.redhat.com/show_bug.cgi?id=831871
Alan Pevec apevec@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |apevec@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #1 from Alan Pevec apevec@redhat.com ---
# Completely bogus group, but Alan Pevec's openstack-swift uses it. Group: Development/Languages
Credit where the credit is due :) This is in openstack-swift since initial import http://pkgs.fedoraproject.org/gitweb/?p=openstack-swift.git;a=blob;f=opensta...
I'll change it in openstack-swift to Applications/System (like in rest openstack-* apps) but not sure what group is the best fit for plugins like this.
E.g. OpenStack python-*client RPMs also have Group: Development/Languages but looking at /usr/share/doc/rpm-*/GROUPS better might be Development/Libraries or just completely drop Group: tag from spec?
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #2 from Pete Zaitcev zaitcev@redhat.com --- I was told by someone that we aim for a drop, distro-wide, but I do not see it in guidelines.
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #3 from Alan Pevec apevec@redhat.com --- Yeah, then let's drop it, guidelines only mention that -doc subpackages should have Group: Documentation
My other remarks from the review: - Source0: should be only filename when it's SCM snapshot http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control - Since it's a pre-release, Release: should be 0.1.%{snapshot_tag} http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_package... - In %files: %{python_sitelib}/*.egg-info would be easier for later updates
Rest of it is ok: MUST OK rpmlint => rpmlint openstack-swift-plugin-swift3-1.0.0-20120612.1.fc16.* 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK name OK spec file name = %{name}.spec American English legible locales %find_lang UTF-8 filenames [-] Packaging Guidelines Needs small adjusments per above remarks.
OK license Fedora approved spec field in %doc OK sources url => git archive --format=tar --prefix=swift3-1.0.0-5c74ba04/ 5c74ba04 | xz - > ../swift3-1.0.0-5c74ba04.tar.xz md5sum => echo "b21822c4fbfaa40f4164b371764abf76 swift3-1.0.0-5c74ba04.tar.xz" | md5sum -c swift3-1.0.0-5c74ba04.tar.xz: OK
OK BuildRequires OK directories own all or require a package no directory conflicts OK no dups in %files (exception: license texts) OK Permissions OK consistently use macros OK code or permissable content
SHOULD OK build in mock => http://koji.fedoraproject.org/koji/taskinfo?taskID=4161481
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #4 from Pete Zaitcev zaitcev@redhat.com --- Updated.
Spec URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3.spec-1.0.... SRPM URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3-1.0.0-0.2...
https://bugzilla.redhat.com/show_bug.cgi?id=831871
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec@gmail.com Flags| |fedora-review+
--- Comment #5 from Alan Pevec apevec@gmail.com --- approved
https://bugzilla.redhat.com/show_bug.cgi?id=831871
Pete Zaitcev zaitcev@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Pete Zaitcev zaitcev@redhat.com --- New Package SCM Request ======================= Package Name: openstack-swift-plugin-swift3 Short Description: The swift3 plugin for Openstack Swift Owners: zaitcev Branches: f17 f18 InitialCC: apevec
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
No need to request f18, currently==devel.
https://bugzilla.redhat.com/show_bug.cgi?id=831871
Pete Zaitcev zaitcev@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2012-06-18 15:15:34
https://bugzilla.redhat.com/show_bug.cgi?id=831871
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #8 from Alan Pevec apevec@gmail.com --- Package Change Request ====================== Package Name: openstack-swift-plugin-swift3 New Branches: el6 Owners: apevec zaitcev
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/openstack-swift-plugin-swift3-1.0.0-...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=831871
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6, openstack-swift-1.7.4-2.el6, python-swiftclient-1.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org