https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Bug ID: 1509590 Summary: Review Request: cool-retro-term - Terminal emulator mimicking a CRT display Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-1.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22924308
Description: cool-retro-term is a terminal emulator which tries to mimic the look and feel of the old cathode tube screens. It has been designed to be eye-candy, customizable, and reasonably lightweight.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #1 from Iwicki Artur fedora@svgames.pl --- I ran the package through fedora-review and a few issues turned up.
spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-2.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22938177
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- You should consider unbundling qmltermwidget...
I did so a while back in a COPR repo: https://copr.fedorainfracloud.org/coprs/ngompa/cool-retro-term/
Feel free to take those for making official packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #3 from Iwicki Artur fedora@svgames.pl --- Thanks! I'll take a look at those.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #4 from Iwicki Artur fedora@svgames.pl --- I unbundled qmltermwidget using the spec files from Neal's copr. I post new links to the spec and srpm below. No koji build due to waiting for the dependency to be accepted.
spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-3.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-3.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1511966
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1511966 [Bug 1511966] Review Request: qmltermwidget - a QML port of QTermWidget
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #6 from Iwicki Artur fedora@svgames.pl --- qmltermwidget, which is a dependency of this package, has been accepted. Hence, I post a link to a koji build. spec and SRPM as in the previous post (1.0.1-3). https://koji.fedoraproject.org/koji/taskinfo?taskID=23288444
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Review notes:
[!] Spec file is named incorrectly. It should be named as cool-retro-term.spec
[!] Non-usage of %qt5_qmake macro. Please consider using it so that our distro-wide compiler settings are applied.
[!] Missing runtime dependency on qmltermwidget. QML modules do not yet have automatic dependencies, so they need to be specified.
[+] Software is licensed under a valid license, and license content is included correctly
[!] Notable issues from rpmlint from fedora-review: - cool-retro-term.x86_64: W: spurious-executable-perm /usr/share/man/man1/cool-retro-term.1.gz
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #8 from Iwicki Artur fedora@svgames.pl --- Thanks for the review. The spec file name inside the SRPM has a correct name; it's just that I prefer to version the linked specs during the review process.
Anyway: spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-4.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-4.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23376633
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- I don't see any remaining issues.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #10 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cool-retro-term
https://bugzilla.redhat.com/show_bug.cgi?id=1509590 Bug 1509590 depends on bug 1511966, which changed state.
Bug 1511966 Summary: Review Request: qmltermwidget - a QML port of QTermWidget https://bugzilla.redhat.com/show_bug.cgi?id=1511966
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a03ca8d850
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dfcc097b97
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b3c73d2cbc
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-603b011e54
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-12f2895029
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-813b682539
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-813b682539
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-12f2895029
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-12-10 00:08:06
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1509590
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- cool-retro-term-1.0.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org