https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Bug ID: 2069453 Summary: Review Request: SDL2_sound - An abstract soundfile decoder library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dominik@greysector.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound.spec SRPM URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound.spec Description: SDL_sound is a library that handles the decoding of several popular sound file formats, such as .WAV and .OGG. It is meant to make the programmer's sound playback tasks simpler. The programmer gives SDL_sound a filename, or feeds it data directly from one of many sources, and then reads the decoded waveform data back at her leisure. If resource constraints are a concern, SDL_sound can process sound data in programmer-specified blocks. Alternately, SDL_sound can decode a whole sound file and hand back a single pointer to the whole waveform. SDL_sound can also handle sample rate, audio format, and channel conversion on-the-fly and behind-the-scenes, if the programmer desires.
Fedora Account System Username: rathann
This is a parallel-installable new major version of SDL_sound. The only conflict is in SDL2_sound-devel from the manpages, so explicit Conflicts: was added.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com CC| |ngompa13@gmail.com Flags| |fedora-review? Doc Type|--- |If docs needed, set a value
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Thanks! Here's the correct link for the SRPM:
Spec URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound.spec SRPM URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound-2.0.1-1.fc36.s...
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1947732
--- Comment #3 from Hans de Goede hdegoede@redhat.com --- *** Bug 2068687 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1947732 [Bug 1947732] ags-3.6.0.22 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@redhat.com
--- Comment #4 from Hans de Goede hdegoede@redhat.com --- Neal, thank you for reviewing this. I also volunteered to review this here: https://src.fedoraproject.org/rpms/SDL_sound/pull-request/1
But I'm happy for you to do it :) Let me know if you need any help.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #5 from Neal Gompa ngompa13@gmail.com ---
%files %license LICENSE.txt %doc docs/CREDITS.txt docs/README.txt %{_bindir}/playsound %{_libdir}/libSDL2_sound.so.2{,.*}
Can you please split out playsound into a subpackage so that this is multilib safe?
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #6 from Hans de Goede hdegoede@redhat.com --- (In reply to Neal Gompa from comment #5)
%files %license LICENSE.txt %doc docs/CREDITS.txt docs/README.txt %{_bindir}/playsound %{_libdir}/libSDL2_sound.so.2{,.*}
Can you please split out playsound into a subpackage so that this is multilib safe?
rpm uses file-coloring, so it is allowed to have /usr/bin/foo in both the i686 and x86_64 package and to install both at the same time; and it is tiny.
I do see that the SDL1 SDL_sound package also installs a /usr/bin/playsound, which actually is a problem. Maybe rename the SDL2 one to playsound2? Or given that the SDL_sound (v1) version is obsolete submit a PR to rename that one out of the way?
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- (In reply to Hans de Goede from comment #6)
(In reply to Neal Gompa from comment #5)
%files %license LICENSE.txt %doc docs/CREDITS.txt docs/README.txt %{_bindir}/playsound %{_libdir}/libSDL2_sound.so.2{,.*}
Can you please split out playsound into a subpackage so that this is multilib safe?
rpm uses file-coloring, so it is allowed to have /usr/bin/foo in both the i686 and x86_64 package and to install both at the same time; and it is tiny.
I do see that the SDL1 SDL_sound package also installs a /usr/bin/playsound, which actually is a problem. Maybe rename the SDL2 one to playsound2? Or given that the SDL_sound (v1) version is obsolete submit a PR to rename that one out of the way?
Maybe instead just remove the binary from SDL_sound, since this effectively replaces that.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #8 from Hans de Goede hdegoede@redhat.com ---
Maybe instead just remove the binary from SDL_sound, since this effectively replaces that.
Yes that would be fine too.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed
PACKAGE APPROVED.
Please adjust SDL_sound to drop the conflicting binaries.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #10 from Hans de Goede hdegoede@redhat.com --- Ok, I'll prepare updated SDL_sound packages for F35+ dropping the play_sound util.
Note I plan to _not_ create bodhi updates for these, the idea being that these will get added to the bodhi update with the new SDL2_sound pkg once those have been build, so please don't forget to add them :)
Let me know if you need the SDL_sound update for any other branches too.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #11 from Hans de Goede hdegoede@redhat.com ---
Ok, I'll prepare updated SDL_sound packages for F35+ dropping the play_sound util.
Done.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #12 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Thanks a lot, Hans. That's really helpful. I'll add the builds to SDL2_sound newpackage update.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
--- Comment #13 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/SDL2_sound
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4cfb2ca145 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4cfb2ca145
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4cfb2ca145 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4cfb2ca145 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4cfb2ca145
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2069453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-05-07 04:17:01
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4cfb2ca145 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org